Date: Fri, 29 Mar 2019 19:36:59 +0100 From: Jan Beich <jbeich@FreeBSD.org> To: Mark Linimon <linimon@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r497170 - in head/graphics/gstreamer1-plugins-gl: . files Message-ID: <o95t-zfw4-wny@FreeBSD.org> In-Reply-To: <201903291721.x2THLQg3042099@repo.freebsd.org> (Mark Linimon's message of "Fri, 29 Mar 2019 17:21:26 %2B0000 (UTC)") References: <201903291721.x2THLQg3042099@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Mark Linimon <linimon@FreeBSD.org> writes:
> I chose a different approach from the PR. The trick is that since this
> is a slave port, the patchdir by default is from the masterport. In my
> fix, I put the patches back into this port's files/ subdir and do some
> Makefile magic to invoke them.
Can you provide the rationale for doing this? Documenting "why?" is more
important than "what?" has changed.
> +EXTRA_PATCHDIR= ${.CURDIR}/../../graphics/gstreamer1-plugins-gl/files
Why indirection i.e., not ${.CURDIR}/files? ${.CURDIR} cannot be changd
by master port.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?o95t-zfw4-wny>