From owner-cvs-all@FreeBSD.ORG  Tue Oct  5 15:37:20 2010
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 57AC61065674;
	Tue,  5 Oct 2010 15:37:20 +0000 (UTC)
	(envelope-from swell.k@gmail.com)
Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com
	[209.85.215.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 377D48FC14;
	Tue,  5 Oct 2010 15:37:18 +0000 (UTC)
Received: by eyx24 with SMTP id 24so3029396eyx.13
	for <multiple recipients>; Tue, 05 Oct 2010 08:37:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:from:to:cc:subject:references
	:date:in-reply-to:message-id:user-agent:mime-version:content-type;
	bh=j702vMzhIEDXCnLL6X3KYTQTpKU9/kRDhQg8lUai8CI=;
	b=V3Dd9dGQF6N3rXWUo+2F27zhpNTAGMFff1cGeOpi0GimEBf44KT3rvre6nHGytQjk0
	XxW1G3QfHgifQ1qwOlUy+DmBEts1f+JfrgFyzfl2e/UXzjJvL/cjZyfafZEi1xWfiJ4Q
	b75PKlpJVndgn3iiqyreVATSMfsSKgNOADE0o=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=from:to:cc:subject:references:date:in-reply-to:message-id
	:user-agent:mime-version:content-type;
	b=r+d5u9F+A7bE7GsVhe3xeXE6wBy5q0QhyD7Esk/u/myaQPi0EzOPwFf1e4w8rplXTl
	TvbmjmtmM/hyw7+iePjA707gjxCsxxHADLyvwpVs74LrhoUnIIO8cUIz4JILqGgqSJ+v
	KeokB1MAakcgJwwMHPv+fBgwwk7NtoSalxJkM=
Received: by 10.103.182.4 with SMTP id j4mr3845552mup.133.1286293037687;
	Tue, 05 Oct 2010 08:37:17 -0700 (PDT)
Received: from localhost (tor-exit-proxy4-readme.formlessnetworking.net
	[208.53.142.40])
	by mx.google.com with ESMTPS id r5sm811599fai.3.2010.10.05.08.37.14
	(version=SSLv3 cipher=RC4-MD5); Tue, 05 Oct 2010 08:37:15 -0700 (PDT)
From: Anonymous <swell.k@gmail.com>
To: Dirk Meyer <dinoex@FreeBSD.org>
References: <201010050846.o958keq8000302@repoman.freebsd.org>
Date: Tue, 05 Oct 2010 19:35:03 +0400
In-Reply-To: <201010050846.o958keq8000302@repoman.freebsd.org> (Dirk Meyer's
	message of "Tue, 5 Oct 2010 08:46:40 +0000 (UTC)")
Message-ID: <8662xgejq0.fsf@gmail.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, bug-followup@FreeBSD.org,
	ports-committers@FreeBSD.org
Subject: Re: ports/150982: [patch] net-p2p/ed2k: typo and wrong amule
	pkgname in CONFLICTS
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Oct 2010 15:37:20 -0000

(subject modified for gnats)

Dirk Meyer <dinoex@FreeBSD.org> writes:

> regression found:
> CFLAGS+= was not passed if you have CFLAGS in /etc/make.conf

Did you by chance use CFLAGS= instead of CFLAGS+= in make.conf?

> dinoex      2010-10-05 08:46:40 UTC
>
>   FreeBSD ports repository
>
>   Modified files:
>     net-p2p/ed2k         Makefile
>   Log:
>   - fix typo: CONFILTCS vs. CONFLICTS

Typo is still there.

>   - use current lowercase amule pkgname in CONFLICTS
>   - don't abuse LDLIBS for CPPFLAGS
>   - use NO_WRKSUBDIR
>   - install verbosely like most ports do
>   PR:             150982
>   Submitted by:   swell.k

>   - Fix PKGNAME logic

It breaks CONFLICTS in amule ports even more.
And remove PKGNAMESUFFIX2 if it's not defined anywhere.