Date: Thu, 6 Jul 2023 12:58:12 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Raphael Kubo da Costa <rakuco@freebsd.org> Cc: "Hurling, Rainer" <rhurlin@freebsd.org>, eduardo@freebsd.org, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: b56d0bc41af7 - main - devel/libcutl: Explain why USE_CXXSTD=c++11 is used Message-ID: <ZKa6ZAH8ePifeg9p@FreeBSD.org> In-Reply-To: <e56d377d0985b86be2291b64bb3c686742283dde.camel@FreeBSD.org> References: <202307050850.3658oPOA049562@gitrepo.freebsd.org> <CAFDf7UJRc4bd3XVq%2Bb7Za2cLN7h_hkN1mpPTGQiSajV1p9A=0g@mail.gmail.com> <ebcdf01a-2b73-39c3-b6e4-25659e53b1ca@gwdg.de> <e56d377d0985b86be2291b64bb3c686742283dde.camel@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 06, 2023 at 10:34:57AM +0200, Raphael Kubo da Costa wrote: > ... > * net-p2p/amule uses the `register` keyword in a bunch of places > (including some autogenerated flex/bison ones that are part of the > tree), and it has been removed/deprecated in C++17. In this case, I'd advise to fix the code instead (i.e. patch out the keyword itself) rather than pinning the port to some particular C++ standard, because C++ ABI is rather fragile and this might cause linking issues in the future when some dependencies would be built in C++17 (20, 23, etc.) mode (by-that-time default) while the port is still forcing C++11. In general, it's always better to fix the code, not mask the bugs out (even though sometimes we kind of have to do this for some obscure codebases). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZKa6ZAH8ePifeg9p>