From owner-cvs-all@FreeBSD.ORG Tue Dec 11 06:50:47 2007 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 78F6716A418; Tue, 11 Dec 2007 06:50:47 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id EB19313C448; Tue, 11 Dec 2007 06:50:46 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8r) with ESMTP id 223910548-1834499 for multiple; Tue, 11 Dec 2007 01:50:46 -0500 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id lBB6odVj064024; Tue, 11 Dec 2007 01:50:40 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: cokane@freebsd.org Date: Tue, 11 Dec 2007 01:32:15 -0500 User-Agent: KMail/1.9.6 References: <200712062311.lB6NBSBD081134@repoman.freebsd.org> <47597900.1070006@FreeBSD.org> In-Reply-To: <47597900.1070006@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200712110132.17695.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 11 Dec 2007 01:50:40 -0500 (EST) X-Virus-Scanned: ClamAV 0.91.2/5080/Tue Dec 11 00:00:57 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_module.c src/sys/compat/freebsd32 freebsd32.h freebsd32_misc.c syscalls.master X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Dec 2007 06:50:47 -0000 On Friday 07 December 2007 11:46:56 am Coleman Kane wrote: > John Baldwin wrote: > > jhb 2007-12-06 23:11:27 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_module.c > > sys/compat/freebsd32 freebsd32.h freebsd32_misc.c > > syscalls.master > > Log: > > Move several data structure definitions out of freebsd32_misc.c and into > > freebsd32.h instead. > > > > MFC after: 1 week > > > > Revision Changes Path > > 1.7 +56 -0 src/sys/compat/freebsd32/freebsd32.h > > 1.69 +36 -83 src/sys/compat/freebsd32/freebsd32_misc.c > > 1.92 +1 -0 src/sys/compat/freebsd32/syscalls.master > > 1.53 +1 -0 src/sys/kern/kern_module.c > > > This commit now causes the following error when building the kernel on > my system: > > cc -c -O2 -frename-registers -pipe -fno-strict-aliasing -march=athlon64 > -std=c99 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes > -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef > -Wno-pointer-sign -fformat-extensions -nostdinc -I. -I/usr/src/sys > -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS > -include opt_global.h -fno-common -finline-limit=8000 --param > inline-unit-growth=100 --param large-function-growth=1000 > -fno-omit-frame-pointer -mcmodel=kernel -mno-red-zone -mfpmath=387 > -mno-sse -mno-sse2 -mno-mmx -mno-3dnow -msoft-float > -fno-asynchronous-unwind-tables -ffreestanding -Werror > /usr/src/sys/compat/freebsd32/freebsd32_misc.c > /usr/src/sys/compat/freebsd32/freebsd32_misc.c: In function 'copy_statfs': > /usr/src/sys/compat/freebsd32/freebsd32_misc.c:153: error: void value > not ignored as it ought to be > *** Error code 1 > > Looking in src/sys/sys, the offending function call, statfs_scale_blocks > is defined as void return type in mount.h but a return value is expected > at this point in freebsd32_misc.c. > > sys/sys/mount.h:void statfs_scale_blocks(struct statfs *sf, long > max_size); Sorry, a part of some statfs 32-bit conversion fixes snuck in. Should all be cleaned up now. -- John Baldwin