Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 24 Sep 2006 05:49:20 -0400
From:      Kris Kennaway <kris@obsecurity.org>
To:        Stanislav Sedov <stas@FreeBSD.org>, sem@FreeBSD.org
Cc:        Kris Kennaway <kris@obsecurity.org>, Rainer Alves <rainer.alves@gmail.com>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, sem@FreeBSD.org, cvs-ports@FreeBSD.org
Subject:   Re: cvs commit: ports/multimedia/avifile Makefile ports/multimedia/avifile/files patch-lib_aviread_ReadFile.cpp
Message-ID:  <20060924094920.GA21944@xor.obsecurity.org>
In-Reply-To: <20060924112959.0f77617a@localhost>
References:  <200609231621.k8NGLNJF090082@repoman.freebsd.org> <20060923222717.GA12790@xor.obsecurity.org> <20060924112959.0f77617a@localhost>

next in thread | previous in thread | raw e-mail | index | archive | help

--SUOF0GtieIMvvwua
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Sep 24, 2006 at 11:29:59AM +0400, Stanislav Sedov wrote:
> On Sat, 23 Sep 2006 18:27:17 -0400
> Kris Kennaway <kris@obsecurity.org> mentioned:
>=20
> > On Sat, Sep 23, 2006 at 04:21:23PM +0000, Stanislav Sedov wrote:
> > > stas        2006-09-23 16:21:23 UTC
> > >=20
> > >   FreeBSD ports repository
> > >=20
> > >   Modified files:
> > >     multimedia/avifile   Makefile=20
> > >   Added files:
> > >     multimedia/avifile/files patch-lib_aviread_ReadFile.cpp=20
> > >   Log:
> > >   - Fix building with recent version of gcc (3.4.6) [1]
> > >   - Test for pcvt_ioctl.h existence as it was removed recently.
> > >     Include iokb.h instead if its'nt exists. [1]
> >=20
> > .if exists() tests to control build behaviour are usually bogus, use
> > an OSVERSION test instead.
> >=20
> > Kris
>=20
> I was thinking about it, but unfortunately there was no revision bump
> after the pcvt(4) removal. Thus I decided to explicitly check for the
> existence.

OK, you'll have to use the next nearest OSVERSION then.

Kris

--SUOF0GtieIMvvwua
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)

iD8DBQFFFlSgWry0BWjoQKURAkB9AKDBxiV8KDK0UfaCkrUtTSFKDq7ZugCgpJlq
hrA5nlirN5WUWaEu/5VqPHo=
=5Dgh
-----END PGP SIGNATURE-----

--SUOF0GtieIMvvwua--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060924094920.GA21944>