From owner-cvs-src@FreeBSD.ORG  Mon Oct 11 21:51:51 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 59BEF16A4CE; Mon, 11 Oct 2004 21:51:51 +0000 (GMT)
Received: from ylpvm15.prodigy.net (ylpvm15-ext.prodigy.net [207.115.57.46])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 190B043D2D; Mon, 11 Oct 2004 21:51:51 +0000 (GMT)
	(envelope-from nate@root.org)
Received: from [10.0.0.34] (adsl-67-119-74-222.dsl.sntc01.pacbell.net
	[67.119.74.222])i9BLq2Wo021745;	Mon, 11 Oct 2004 17:52:02 -0400
Message-ID: <416B0075.1020006@root.org>
Date: Mon, 11 Oct 2004 14:51:49 -0700
From: Nate Lawson <nate@root.org>
User-Agent: Mozilla Thunderbird 0.7.3 (X11/20040901)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: John Baldwin <jhb@FreeBSD.org>
References: <200410111952.i9BJqVXl083724@repoman.freebsd.org>
	<200410111608.18915.jhb@FreeBSD.org>
In-Reply-To: <200410111608.18915.jhb@FreeBSD.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: 
	Re: cvs commit: src/sys/dev/sound/isa ad1816.c es1888.c gusc.c sbc.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Oct 2004 21:51:51 -0000

John Baldwin wrote:
> On Monday 11 October 2004 03:52 pm, Nate Lawson wrote:
> 
>>njl         2004-10-11 19:52:31 UTC
>>
>>  FreeBSD src repository
>>
>>  Modified files:
>>    sys/dev/sound/isa    ad1816.c es1888.c gusc.c sbc.c
>>  Log:
>>  Add acpi attachments for ISA sound drivers.  This is needed so they'll
>>  probe and attach when ACPI is enabled.
>>
>>  Submitted by:   takawata (sbc fix)
>>  MFC after:      1 day
> 
> This should only be needed for PnP BIOS cards, not just plain old ISA PnP 
> cards.  The es1888.c file is only a driver on Alpha in fact as it basically 
> includes a dummy identify routine to make up for the lack of PnP BIOS on 
> Alphas.

Which of those cards should have the acpi attachment removed?  I think 
it should be:

* Removed from es1888.c
* Added to ess.c:esscontrol
* Moved from mss.c:snd_mss to snd_pnpmss

-Nate