From owner-freebsd-stable@FreeBSD.ORG Fri Jun 10 23:42:29 2011 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8CF841065670 for ; Fri, 10 Jun 2011 23:42:29 +0000 (UTC) (envelope-from jdc@koitsu.dyndns.org) Received: from qmta14.emeryville.ca.mail.comcast.net (qmta14.emeryville.ca.mail.comcast.net [76.96.27.212]) by mx1.freebsd.org (Postfix) with ESMTP id 75E8F8FC0C for ; Fri, 10 Jun 2011 23:42:29 +0000 (UTC) Received: from omta15.emeryville.ca.mail.comcast.net ([76.96.30.71]) by qmta14.emeryville.ca.mail.comcast.net with comcast id uPai1g0041Y3wxoAEPiTLP; Fri, 10 Jun 2011 23:42:27 +0000 Received: from koitsu.dyndns.org ([67.180.84.87]) by omta15.emeryville.ca.mail.comcast.net with comcast id uPi71g00D1t3BNj8bPi7Wy; Fri, 10 Jun 2011 23:42:08 +0000 Received: by icarus.home.lan (Postfix, from userid 1000) id C708B102C19; Fri, 10 Jun 2011 16:42:27 -0700 (PDT) Date: Fri, 10 Jun 2011 16:42:27 -0700 From: Jeremy Chadwick To: d@delphij.net Message-ID: <20110610234227.GA54846@icarus.home.lan> References: <20110610221525.A1C791CC0B@ptavv.es.net> <4DF2A5AC.6070804@delphij.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DF2A5AC.6070804@delphij.net> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-stable@freebsd.org Subject: Re: Unable to boot Lenovo T520 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jun 2011 23:42:29 -0000 On Fri, Jun 10, 2011 at 04:15:56PM -0700, Xin LI wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On 06/10/11 15:15, Kevin Oberman wrote: > > I am hitting the problem reported some time ago with atkbd and svn > > 197392. > > > > It's not clear that this has ben finally resolved, but I am still > > hitting it with -stable on my new T520. I really want to get FreeBSD up > > on it, but I am dead in the water at this time. I guess I'll have to > > build a new kernel with any fix and replace the kernel in the ISO. > > > > Also, I am hoping to use it on an amd64 kernel and I am even less sure > > that any patch will work on that arch. > > > > The original thread was > > http://freebsd.1045724.n5.nabble.com/svn-rev-197392-hangs-during-boot-td3926276.html > > The fix was not (yet) merged back to 8-STABLE. You may use a > 8.0-RELEASE kernel to boot the system temporarily and apply this patch: > > http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/atkbdc/atkbd.c.diff?r1=1.63;r2=1.64 > > (If hunk #1 fails to apply, it's Ok to just ignore it). Specifically: http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/atkbdc/atkbd.c#rev1.64 - if (x86bios_get_intr(0x15) == 0 || x86bios_get_intr(0x16) == 0) + if (x86bios_get_intr(0x15) != 0xf000f859 || + x86bios_get_intr(0x16) != 0xf000e82e) What are these magic numbers? Where did they come from? What do they represent? Why are they not documented in the source code/commit itself? No offence, but this is an open-source project; anyone looking at this code isn't going to know what those vectors represent. The commit message is also lacking (again: magic values not mentioned), and expecting a developer to dig through commits/annotations to determine what this piece of code is for is unreasonable. No I'm not in a bad mood (honest!), I just find this kind of thing infuriating the more I dig through kernel source code. -- | Jeremy Chadwick jdc@parodius.com | | Parodius Networking http://www.parodius.com/ | | UNIX Systems Administrator Mountain View, CA, US | | Making life hard for others since 1977. PGP 4BD6C0CB |