From nobody Wed Feb 9 10:08:44 2022 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 44C3619AE65A for ; Wed, 9 Feb 2022 10:08:48 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JtwZS0xptz3MTW; Wed, 9 Feb 2022 10:08:48 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1644401328; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Weamu8tG/QKR9m/WOOLvJSs6BPO8tQNObhe5i6eLvOE=; b=LFp6zbV+MHotZsVcIbpcPGHt+qu3uAnqgIoocbuaOXy3NKAwzgF52GcHmTZa76bpCsx4iv zLifGdFymnQ32/4+r6W0H1KyaV7q/AXalitNfwTQpqR+856x2pS/leLYfJh2FpoiezotvZ EDf9MjxTFIy82CgaduakUNEXuQdGNHkJmihpKEBBBYTUNd5/Lhbru5hT7dNrAfsy9k5P/F /oVGjUzZIweziJmnZI93mFbRNDXoDXLhu28njrM3S21sXHQ+weCP1hbS3eNAmiZSLRFee6 vMvq04jh9PEgewGrG4emQ9cZbz8Oi08fjzetgMWE4Y63C2T80KmkbRdwdZ8v7Q== Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id C6ABD22DDC; Wed, 9 Feb 2022 10:08:47 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 91608240EF; Wed, 9 Feb 2022 11:08:45 +0100 (CET) From: Kristof Provost To: Gary Jennejohn Cc: current@freebsd.org Subject: Re: test-includes breaks buildworld when WITHOUT_PF is set in src.conf Date: Wed, 09 Feb 2022 11:08:44 +0100 X-Mailer: MailMate (1.14r5852) Message-ID: <7E81E26A-1296-4107-8379-53A9F2C0DCE6@FreeBSD.org> In-Reply-To: <20220209105752.2c382ac2@ernst.home> References: <20220209105752.2c382ac2@ernst.home> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1644401328; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Weamu8tG/QKR9m/WOOLvJSs6BPO8tQNObhe5i6eLvOE=; b=P0EG8epvk9xApe6YoESoj7aWdtRdc9uhugjMC0h1tx3/VM6jsBfp4FKzTT/A6jjPYkySX9 XE8dAhBu+MFPmb5L1f7NR46z3SpJDtq9M4rrj6i3d/JqICgPb60m1aSWTnEE1URYEncCpd V8PTp/O7UyAoLeeONAGhS6YfF5+puGyzHz7pXzK4GuV59+2IL4y7zzZkJDwQIXxUgZXlJf 28Hrz2J9E9Sf/xYHXOoowFWjpZo6n+UxDjc7vTLxWl5Rec9NVQJUuuMDnXlOZrqdrHBzaJ aqTYj1nZ//JVh7gro8T/R68qche35V8XKfB38gyVe35QJCWFnRALbzqMhsNdow== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1644401328; a=rsa-sha256; cv=none; b=cGWbIhFLUtrBp6CEaSMAbswvSYD3hwRfIaZEUGc9JvmDPNNaDTf4sf8+prTTXs5oSCV65w 7QH+3+G0L5RvYnn000G5D3nyViGp7i9k2RqMQecisq0/oZJqsu3wdnO3xaW5ROuCIFXf26 86vwRFVSIuSHlYvrLcul/iTf46Q9qlY2uGGTD/8RkMS7yfZnBkeRkcbt1jQ5brO0NSQSgk SCSavNZO8op+uvYnH56DwHCalF8BAoZN6jFjygtNXDTGGliVtEO7LAow/dV9Dwhpkq0AKS t7BkZNdK74AdThU4FgRyl2SbYOB0dbvAV8YD5YMvvXCbFZ4UbxS4/9JPBgmOEA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 9 Feb 2022, at 10:57, Gary Jennejohn wrote: > test-includes uses pf.h when checking usage of pfvar.h. > > But, these lines in include/Makefile remove pf.h when WITHOUT_PF is > set in src.conf: > > .if ${MK_PF} !=3D "no" > INCSGROUPS+=3D PF > .endif > > This breaks buildworld. The error message: > > In file included from net_pfvar.c:1: > /usr/obj/usr/src/amd64.amd64/tmp/usr/include/net/pfvar.h:65:10: fatal e= rror: > 'netpfil/pf/pf.h' file not found > #include > ^~~~~~~~~~~~~~~~~ > 1 error generated. > --- net_pfvar.o --- > *** [net_pfvar.o] Error code 1 > > make[3]: stopped in /usr/src/tools/build/test-includes > .ERROR_TARGET=3D'net_pfvar.o' > > Removing the .if/.endif fixes it for me, although there may be a better= > way to avoid the error. > Warner=E2=80=99s working on a better fix. See https://reviews.freebsd.org= /D34009 for the discussion. Kristof