From owner-svn-ports-head@freebsd.org Fri Feb 16 16:52:11 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C9947F2456D; Fri, 16 Feb 2018 16:52:11 +0000 (UTC) (envelope-from feld@FreeBSD.org) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 713EF8544B; Fri, 16 Feb 2018 16:52:11 +0000 (UTC) (envelope-from feld@FreeBSD.org) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id AEBED20BF5; Fri, 16 Feb 2018 11:52:09 -0500 (EST) Received: from web4 ([10.202.2.214]) by compute3.internal (MEProxy); Fri, 16 Feb 2018 11:52:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=BeHc87 QlEkbRyJbrNJssCgUy3v99p3G+5SHXNXh9Fkk=; b=UiZUFhe5HHMYr4uUfDLiyq 01bOGqi/8tR/BP5NOekX+DCzG8UoyDhg4gE00g+6R7OAB6n4KuOtKGAACJCmKYgC eVNplzyVfXJvPAbtgnSlytaujrCIFj645fDxGHYXM2P3n/EgznfhkJPUCGd8jtQ2 nzq30p1adsyrgUVs9gtQ5uNjDCT3mI1AJID6BMwoYvEiuiUVkesj1DCO2JJcFEL0 c8ysLY3uwzxVtj/eqKOsfGah/pViH6WWGVK4sfBXijhXrOJAVlaLHNdYdgDZr90Y bGczwm7BkW9UuqZbsDvhprN8lf0hAoL+5BI1KZ9JIFGH15MASHGWYOLS54R2FBJQ == X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id 898A2BA43B; Fri, 16 Feb 2018 11:52:09 -0500 (EST) Message-Id: <1518799929.3798113.1273296336.4F94C55E@webmail.messagingengine.com> From: Mark Felder To: Tijl Coosemans Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-1b99b2df In-Reply-To: <20180216174106.125d61af@kalimero.tijl.coosemans.org> Subject: Re: svn commit: r461746 - head/security/ca_root_nss Date: Fri, 16 Feb 2018 10:52:09 -0600 References: <201802132045.w1DKjdOQ093642@repo.freebsd.org> <20180214141840.583d247a@kalimero.tijl.coosemans.org> <1518795735.3761657.1273209560.03AB7B50@webmail.messagingengine.com> <20180216174106.125d61af@kalimero.tijl.coosemans.org> X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Feb 2018 16:52:12 -0000 On Fri, Feb 16, 2018, at 10:41, Tijl Coosemans wrote: > On Fri, 16 Feb 2018 09:42:15 -0600 Mark Felder wrote: > > On Wed, Feb 14, 2018, at 07:18, Tijl Coosemans wrote: > >> On Tue, 13 Feb 2018 20:45:39 +0000 (UTC) Mark Felder wrote: > >>> Modified: head/security/ca_root_nss/pkg-plist > >>> ============================================================================== > >>> --- head/security/ca_root_nss/pkg-plist Tue Feb 13 20:25:50 2018 (r461745) > >>> +++ head/security/ca_root_nss/pkg-plist Tue Feb 13 20:45:38 2018 (r461746) > >>> @@ -3,3 +3,4 @@ > >>> @sample openssl/cert.pem.sample > >>> %%ETCSYMLINK%%/etc/ssl/cert.pem > >>> %%ETCSYMLINK%%@dir /etc/ssl > >>> +@postexec [ -x %%LOCALBASE%%/bin/cert-sync ] && %%LOCALBASE%%/bin/cert-sync --quiet %%PREFIX%%/share/certs/ca-root-nss.crt > >> > >> This command returns an error if the executable doesn't exist. You > >> should invert the logic: > >> > >> @postexec [ ! -x %%LOCALBASE%%/bin/cert-sync ] || %%LOCALBASE%%/bin/ > >> cert-sync --quiet %%PREFIX%%/share/certs/ca-root-nss.crt > > > > What did the error look like? I wasn't seeing anything in my testport > > runs. I intentionally reversed the logic from the original submitter for > > readability and now feel like a fool. :-) > > Installing ca_root_nss-3.35_1... > pkg-static: POST-INSTALL script failed > > Logically, "condition && command" is a conjunction (returns true if both > sides are true) while "!condition || command" is an implication like "if > condition then command". If-then may be more readable though. > > I changed -x to -e because I think it's informative to report an error if > the command exists but isn't executable. > Thanks. Feedback appreciated. -- Mark Felder ports-secteam & portmgr member feld@FreeBSD.org