From owner-freebsd-hackers@FreeBSD.ORG Mon Apr 20 17:48:13 2009 Return-Path: Delivered-To: hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B1A12106567E for ; Mon, 20 Apr 2009 17:48:13 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from vlakno.cz (77-93-215-190.static.masterinter.net [77.93.215.190]) by mx1.freebsd.org (Postfix) with ESMTP id 6CE3F8FC26 for ; Mon, 20 Apr 2009 17:48:12 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from localhost (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id A1EFF9CB0EF; Mon, 20 Apr 2009 19:46:58 +0200 (CEST) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by localhost (lev.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Lcl6joiYdvFo; Mon, 20 Apr 2009 19:46:56 +0200 (CEST) Received: from vlk.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id F2C0A9CB2C1; Mon, 20 Apr 2009 19:46:55 +0200 (CEST) Received: (from rdivacky@localhost) by vlk.vlakno.cz (8.14.3/8.14.3/Submit) id n3KHktfX003777; Mon, 20 Apr 2009 19:46:55 +0200 (CEST) (envelope-from rdivacky) Date: Mon, 20 Apr 2009 19:46:55 +0200 From: Roman Divacky To: Alexey Shuvaev Message-ID: <20090420174655.GA3708@freebsd.org> References: <20090420084118.GA16337@freebsd.org> <49EC3E96.50208@fs.ei.tum.de> <20090420140219.GA74839@freebsd.org> <20090420162411.GA50951@wep4035.physik.uni-wuerzburg.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090420162411.GA50951@wep4035.physik.uni-wuerzburg.de> User-Agent: Mutt/1.4.2.3i Cc: hackers@freebsd.org Subject: Re: [PATCH]: today highlighting in [n]cal X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2009 17:48:14 -0000 On Mon, Apr 20, 2009 at 06:24:11PM +0200, Alexey Shuvaev wrote: > On Mon, Apr 20, 2009 at 04:02:19PM +0200, Roman Divacky wrote: > > On Mon, Apr 20, 2009 at 11:21:26AM +0200, Simon 'corecode' Schubert wrote: > > > Hey Roman, > > > > > > Roman Divacky wrote: > > > >I made this patch that highlights today in cal/ncal just like gnu > > > >cal does.. > > > > > > > > www.vlakno.cz/~rdivacky/cal.patch > > > > > > Thanks for this patch, I've been meaning to hack one up properly, but > > > never got to it. They problems I was facing seem to exist also with your > > > patch: > > > > > > - only works for wide (cal) mode, not ncal mode > > > - probably won't work properly with year displays: the year printing > > > parts of the code use a length argument to printf ("%*s"), which will > > > confuse escape sequences with actual printed characters > > > > after addressing Simon's concerns here's a new patch: > > > > www.vlakno.cz/~rdivacky/cal2.patch > > > > this disables the highlighting for year printing because it's broken > > and introduces the highlighting to ncal as well... > > > Nice! > It depends on one more lib now: > > Modified: > ~> ldd /usr/bin/ncal > /usr/bin/ncal: > libcalendar.so.4 => /usr/lib/libcalendar.so.4 (0x800643000) > libncurses.so.7 => /lib/libncurses.so.7 (0x800745000) > libc.so.7 => /lib/libc.so.7 (0x80088f000) > > Old: > ~> ldd /home/jails/kde4/usr/bin/ncal > /home/jails/kde4/usr/bin/ncal: > libcalendar.so.4 => /usr/lib/libcalendar.so.4 (0x800642000) > libc.so.7 => /lib/libc.so.7 (0x800744000) yes.... so? > Does it work good in single user mode? > (Don't want to go to it right now myself). > OTOH, who needs cal/ncal in single user mode? :) I guess it should.. it depends strictly on terminal, didnt test it though