From owner-freebsd-scsi@FreeBSD.ORG  Thu Feb  3 23:53:14 2011
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
Delivered-To: freebsd-scsi@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DF7E9106564A;
	Thu,  3 Feb 2011 23:53:14 +0000 (UTC)
	(envelope-from joachim@tingvold.com)
Received: from smtp.domeneshop.no (smtp.domeneshop.no [194.63.248.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 985328FC18;
	Thu,  3 Feb 2011 23:53:14 +0000 (UTC)
Received: from aannecy-552-1-139-161.w86-200.abo.wanadoo.fr ([86.200.147.161]
	helo=keklolwtf.home)
	by smtp.domeneshop.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.72) (envelope-from <joachim@tingvold.com>)
	id 1Pl8zA-00066g-OV; Fri, 04 Feb 2011 00:53:13 +0100
Mime-Version: 1.0 (Apple Message framework v1076)
Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes
From: Joachim Tingvold <joachim@tingvold.com>
In-Reply-To: <20110203221056.GA25389@nargothrond.kdm.org>
Date: Fri, 4 Feb 2011 00:53:07 +0100
Content-Transfer-Encoding: 7bit
Message-Id: <EF8D9C50-B601-4A16-8CB3-DF958EBE6AB9@tingvold.com>
References: <B2CFC8A1-FA1D-4718-99C3-AC3430A905C2@tingvold.com>
	<41C64262-4300-4187-B5FD-04A5EFB7F87C@tingvold.com>
	<20110113203750.GA39494@nargothrond.kdm.org>
	<B22C5568-24D0-4530-B90A-BA6A6CAF111C@tingvold.com>
	<20110114001758.GA12793@nargothrond.kdm.org>
	<D24332F3-56AF-484C-9592-1097BF684E37@tingvold.com>
	<07392102-4584-4690-9188-5202728CC7CA@tingvold.com>
	<20110120155746.GA22515@nargothrond.kdm.org>
	<BC40CE83-6116-49CD-8D37-5BC29893449D@tingvold.com>
	<070C12D5-A54F-4A48-A151-EBA16EF32A13@tingvold.com>
	<20110203221056.GA25389@nargothrond.kdm.org>
To: Kenneth D. Merry <ken@freebsd.org>
X-Mailer: Apple Mail (2.1076)
Cc: freebsd-scsi@freebsd.org, Alexander Motin <mav@freebsd.org>
Subject: Re: mps0-troubles
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Feb 2011 23:53:15 -0000

On Thu, Feb 03, 2011, at 23:10:56PM GMT+01:00, Kenneth D. Merry wrote:
> I've attached a patch that has a number of debugging sysctls, a  
> change from
> gibbs@ that has to do with device removal, and some other extra  
> debugging
> cruft.  (i.e. this patch won't go into the tree as-is, it's just for
> debugging.)

	Index: mps.c
	|===================================================================
	|--- mps.c	(revision 218241)
	|+++ mps.c	(working copy)
	--------------------------
	Patching file mps.c using Plan A...
	Hunk #1 succeeded at 386 (offset -1 lines).
	Hunk #2 succeeded at 734 (offset -7 lines).
	Hunk #3 succeeded at 812 (offset -9 lines).
	Hunk #4 failed at 847.

The patch is looking for

	SYSCTL_ADD_UINT(&sc->sysctl_ctx, SYSCTL_CHILDREN(sc->sysctl_tree),  
[...]
	SYSCTL_ADD_UINT(&sc->sysctl_ctx, SYSCTL_CHILDREN(sc->sysctl_tree),  
[...]

but my mps.c has

	SYSCTL_ADD_INT(&sc->sysctl_ctx, SYSCTL_CHILDREN(sc->sysctl_tree), [...]
	SYSCTL_ADD_INT(&sc->sysctl_ctx, SYSCTL_CHILDREN(sc->sysctl_tree), [...]

That, and all the offsets; maybe my mps-driver is a bit outdated?  
Maybe this is a stupid question, but I'm no FreeBSD-expert. (-:

-- 
Joachim