From owner-svn-ports-all@FreeBSD.ORG  Sun Apr 20 14:48:33 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 2804DFA; Sun, 20 Apr 2014 14:48:33 +0000 (UTC)
Date: Sun, 20 Apr 2014 14:48:33 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Joe Marcus Clarke <marcus@FreeBSD.org>
Subject: Re: svn commit: r351606 - head/net/netatalk
Message-ID: <20140420144833.GB89106@FreeBSD.org>
References: <201404191907.s3JJ7gAR096735@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201404191907.s3JJ7gAR096735@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Apr 2014 14:48:33 -0000

On Sat, Apr 19, 2014 at 07:07:42PM +0000, Joe Marcus Clarke wrote:
> New Revision: 351606
> URL: http://svnweb.freebsd.org/changeset/ports/351606
> QAT: https://qat.redports.org/buildarchive/r351606/
> 
> Log:
>   * Convert to STAGE
>   * Only enable AppleTalk support on versions of FreeBSD that support it [1]
>   
> [...]
> +APPLETALK_DESC=	AppleTalk protocol support (where supported)

This change is bogus.  You could've simply make this option conditional.  For
example, cf. games/doomlegacy:

.if exists(/usr/include/netipx/ipx.h)
OPTIONS_DEFINE+=	IPX
IPX_DESC=	IPX protocol support
.endif

> -.if ${PORT_OPTIONS:MAPPLETALK}
> +.if ${OSVERSION} < 1100013 && ${PORT_OPTIONS:MAPPLETALK}

Is it possible to use exists() here instead of OSVERSION?  We're generally
trying to get rid of OSVERSION checks...

./danfe