From owner-cvs-src@FreeBSD.ORG  Mon Nov 10 20:02:57 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AD3D916A4D0
	for <cvs-src@FreeBSD.org>; Mon, 10 Nov 2003 20:02:57 -0800 (PST)
Received: from relay.pair.com (relay.pair.com [209.68.1.20])
	by mx1.FreeBSD.org (Postfix) with SMTP id 3A89D43FEC
	for <cvs-src@FreeBSD.org>; Mon, 10 Nov 2003 20:02:55 -0800 (PST)
	(envelope-from silby@silby.com)
Received: (qmail 30691 invoked from network); 11 Nov 2003 04:02:54 -0000
Received: from niwun.pair.com (HELO localhost) (209.68.2.70)
  by relay.pair.com with SMTP; 11 Nov 2003 04:02:54 -0000
X-pair-Authenticated: 209.68.2.70
Date: Mon, 10 Nov 2003 22:02:52 -0600 (CST)
From: Mike Silbersack <silby@silby.com>
To: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <20031110.170151.81945639.imp@bsdimp.com>
Message-ID: <20031110215128.F6320@odysseus.silby.com>
References: <sam@errno.com> <200311102359.hAANx2xu023566@mta7.pltn13.pbi.net>
 <20031110.170151.81945639.imp@bsdimp.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: sam@errno.com
cc: hsu@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/sys/netinet tcp_syncache.c 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Nov 2003 04:02:57 -0000


On Mon, 10 Nov 2003, M. Warner Losh wrote:

> In message: <200311102359.hAANx2xu023566@mta7.pltn13.pbi.net>
>             Jeffrey Hsu <hsu@FreeBSD.org> writes:
> : Are you kidding me?  Or do you really not understand why it's not
> : Giant-free ready yet?
>
> While it may be obvious to you, it seems that a sentence or two about
> how it isn't giant-free would be useful.
>
> Warner

If I'm not mistaken, syncache_timer calls syncache_respond, which then
goes and interacts with the routing table and ip stack.  Along with the
rest of the non-locked code, it sure looks like it's not-MPSAFE to me.

It seems "obvious" that the code isn't giant-free, given that there are no
locking assertions in it whatsoever.

Mike "Silby" Silbersack