From owner-freebsd-ports@FreeBSD.ORG  Thu Nov 18 17:18:41 2010
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 20494106566B
	for <ports@freebsd.org>; Thu, 18 Nov 2010 17:18:41 +0000 (UTC)
	(envelope-from rfarmer@predatorlabs.net)
Received: from mail-qw0-f54.google.com (mail-qw0-f54.google.com
	[209.85.216.54])
	by mx1.freebsd.org (Postfix) with ESMTP id D39608FC08
	for <ports@freebsd.org>; Thu, 18 Nov 2010 17:18:40 +0000 (UTC)
Received: by qwd6 with SMTP id 6so478214qwd.13
	for <ports@freebsd.org>; Thu, 18 Nov 2010 09:18:40 -0800 (PST)
MIME-Version: 1.0
Received: by 10.224.2.202 with SMTP id 10mr828208qak.60.1290100719266; Thu, 18
	Nov 2010 09:18:39 -0800 (PST)
Received: by 10.220.16.199 with HTTP; Thu, 18 Nov 2010 09:18:39 -0800 (PST)
X-Originating-IP: [128.95.133.115]
In-Reply-To: <AANLkTimkLmZNVWE1XG4vekHtYYrWWRk9-Jq8shJVdze1@mail.gmail.com>
References: <4CE5280E.3090009@zedat.fu-berlin.de>
	<AANLkTin5v4NDNQyYDBCJ=r0OUo33vSqLF5a6rYCZQaS2@mail.gmail.com>
	<20101118160804.GA73849@eggman.experts-exchange.com>
	<AANLkTimkLmZNVWE1XG4vekHtYYrWWRk9-Jq8shJVdze1@mail.gmail.com>
Date: Thu, 18 Nov 2010 09:18:39 -0800
Message-ID: <AANLkTi=N=aG5=swOLjCL0041SZfhq501tE047Rg_H44G@mail.gmail.com>
From: Rob Farmer <rfarmer@predatorlabs.net>
To: Eir Nym <eirnym@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: ports@freebsd.org, Jason Helfman <jhelfman@e-e.com>
Subject: Re: Mk/bsd.command.mk: missing CSH tag
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Nov 2010 17:18:41 -0000

On Thu, Nov 18, 2010 at 08:13, Eir Nym <eirnym@gmail.com> wrote:
> On 18 November 2010 19:08, Jason Helfman <jhelfman@e-e.com> wrote:
>> Wrote a quick patch:
>> --- bsd.commands.mk.orig =A0 =A0 =A0 =A02010-11-18 08:05:47.000000000 -0=
800
>> +++ bsd.commands.mk =A0 =A0 2010-11-18 08:06:17.000000000 -0800
>> @@ -76,6 +76,7 @@
>> =A0SED?=3D =A0 =A0 =A0 =A0 =A0/usr/bin/sed
>> =A0SETENV?=3D =A0 =A0 =A0 /usr/bin/env
>> =A0SH?=3D =A0 =A0 =A0 =A0 =A0 /bin/sh
>> +CSH?=3D =A0 =A0 =A0 =A0 =A0/bin/csh
>> =A0SORT?=3D =A0 =A0 =A0 =A0 /usr/bin/sort
>> =A0STRIP_CMD?=3D =A0 =A0/usr/bin/strip
>> =A0# Command to run commands as privileged user
>>

The patch should probably retain alphabetical order.

>
> Your patch should check if tcsh is in system. it is optional component.

Why? What do you suggest happens if it isn't found? Nothing will break
except stuff that uses the variable and it would use the variable
because it needs csh. It is part of the base system (/bin/csh and
/bin/tcsh) for all supported releases.

--=20
Rob Farmer