From owner-freebsd-ports Tue Jan 20 01:47:57 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id BAA21195 for freebsd-ports-outgoing; Tue, 20 Jan 1998 01:47:57 -0800 (PST) (envelope-from owner-freebsd-ports@FreeBSD.ORG) Received: from lsd.relcom.eu.net (ache@lsd.relcom.eu.net [193.124.23.23]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA21186; Tue, 20 Jan 1998 01:47:51 -0800 (PST) (envelope-from ache@lsd.relcom.eu.net) Received: (from ache@localhost) by lsd.relcom.eu.net (8.8.8/8.8.8) id MAA23937; Tue, 20 Jan 1998 12:46:49 +0300 (MSK) (envelope-from ache) Date: Tue, 20 Jan 1998 12:46:47 +0300 (MSK) From: =?KOI8-R?B?4c7E0sXKIP7F0s7P1w==?= X-Sender: ache@lsd.relcom.eu.net To: Dmitrij Tejblum cc: Dmitrij Tejblum , freebsd-ports@FreeBSD.ORG, committers@FreeBSD.ORG Subject: Re: amanda port, empty PATCH_STRIP= lines causes trouble In-Reply-To: <199801200940.MAA02073@tejblum.dnttm.rssi.ru> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Tue, 20 Jan 1998, Dmitrij Tejblum wrote: > I never sayed that old behavior was better. It, apparently, was very unclear, > and this is why maintainers of GNU patch changed it. But it is, indeed, > outside of scope of this subject. The fact (slightly oversimplified) is that > old (not hacked) patch could correctly apply *most* (old) CVS diffs, while new > patch cannot. (FreeBSD-hacked patch could apply *all* CVS diffs, but not > hacked could apply *most*). "Most" correct variant is even worse that incorrect one. I.e. any correctness probability less then 100% is simple not correct. For patch: Makefile's is usual case, since they are often in every directory. Old patch cause upper level Makefile will be patched instead of one resides lower in the directory tree. If Makefiles are almost equal, this patch can even apply sucessfully, which leads to hardly detected error. -- Andrey A. Chernov http://www.nagual.pp.ru/~ache/