From owner-svn-ports-all@freebsd.org  Sat Oct 24 15:41:00 2015
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4712DA1D0D7;
 Sat, 24 Oct 2015 15:41:00 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 3A7F4198D;
 Sat, 24 Oct 2015 15:41:00 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 3962514D3; Sat, 24 Oct 2015 15:41:00 +0000 (UTC)
Date: Sat, 24 Oct 2015 15:41:00 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Kris Moore <kris@pcbsd.org>
Cc: Kris Moore <kmoore@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject: Re: svn commit: r400121 - head/net-im/teamwords
Message-ID: <20151024154100.GA2659@FreeBSD.org>
References: <201510241406.t9OE6uXi043030@repo.freebsd.org>
 <20151024142932.GB69999@FreeBSD.org> <562B9F65.4010603@pcbsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <562B9F65.4010603@pcbsd.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Oct 2015 15:41:00 -0000

On Sat, Oct 24, 2015 at 11:10:29AM -0400, Kris Moore wrote:
> On 10/24/2015 10:29, Alexey Dokuchaev wrote:
> > On Sat, Oct 24, 2015 at 02:06:56PM +0000, Kris Moore wrote:
> >> [...]
> >>  do-install:
> >>  	${STRIP_CMD} ${WRKSRC}/teamwords
> >>  	${INSTALL} ${WRKSRC}/teamwords ${STAGEDIR}${PREFIX}/bin
> > 
> > Wait, what?  You strip the binary first and then install it?  Why not
> > use ${INSTALL_PROGRAM} which DTRT itself?
> 
> It's what was suggested when I built the port with DEVELOPER=yes. Is the
> end-result the same or is this just for the sake of minimalism?

I'm not sure where does this suggestion come from; it makes little sense
to me.  INSTALL_PROGRAM correctly respects your stripping policy, i.e.:

  $ make -V INSTALL_PROGRAM
  install  -s -m 555
  $ make -V INSTALL_PROGRAM STRIP=''
  install   -m 555

As for stripping binaries explicitly in the Makefile: I'm actually against
it; it made sense in pre-staging times when we've been installing stuff
directly into user's filesystem, but now with staging we ideally should be
just dumping unstripped binaries to staging area, and stripping should be
done upon "make install" by the framework.  Those ${STRIP_CMD}'s just make
Makefiles more imperative and hard to control.  Think of what would I have
to do if I want to build debug package? -- patching individual ports on an
ad-hoc basis in many little places instead of setting some universal knob
like NO_STRIP in /etc/make.conf or something.

So far consensus is to use ${INSTALL_PROGRAM} and/or set INSTALL_TARGET
to `install-strip' when supported instead of doing it correctly.  Oh well.

> That being said, I've changed it now.

Thank you.

./danfe