From owner-freebsd-ports@FreeBSD.ORG Fri Mar 27 12:49:52 2009 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7F808106566B; Fri, 27 Mar 2009 12:49:52 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from smtp.timeweb.ru (smtp.timeweb.ru [217.170.79.85]) by mx1.freebsd.org (Postfix) with ESMTP id 396CC8FC12; Fri, 27 Mar 2009 12:49:52 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from [213.148.20.85] (helo=hive.panopticon) by smtp.timeweb.ru with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.69) (envelope-from ) id 1LnBVR-0002Ah-DK; Fri, 27 Mar 2009 15:49:53 +0300 Received: from hades.panopticon (hades.panopticon [192.168.0.32]) by hive.panopticon (Postfix) with ESMTP id 62531DC63; Fri, 27 Mar 2009 15:48:05 +0300 (MSK) Received: by hades.panopticon (Postfix, from userid 1000) id 6991910883C; Fri, 27 Mar 2009 15:48:38 +0300 (MSK) Date: Fri, 27 Mar 2009 15:48:38 +0300 From: Dmitry Marakasov To: Pav Lucistnik Message-ID: <20090327124838.GM1964@hades.panopticon> References: <1237901632.1849.19.camel@pav.hide.vol.cz> <20090326174632.GB19722@hades.panopticon> <1238108060.268.1.camel@hood.oook.cz> <20090327010223.GK1964@hades.panopticon> <1238139614.71596.2.camel@hood.oook.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1238139614.71596.2.camel@hood.oook.cz> User-Agent: Mutt/1.5.19 (2009-01-05) Cc: ports@FreeBSD.org Subject: Re: HEADS UP multi processor compilations for everyone X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Mar 2009 12:49:52 -0000 * Pav Lucistnik (pav@FreeBSD.org) wrote: > > second > > also improves MAKE_JOBS_* handling, shortening it a bit and exposing > > MAKE_JOBS_NUMBER to the ports, so it can be used for other build systems > > without having to parse out -j from _MAKE_JOBS (and defaults to 1 if > > jobs support is disabled). > > This one I cannot accept, because it adds back != call I made a big > effort to avoid. We can't have one != call per port during building > INDEX. Understood. I still think it'd be nice to expose number of jobs as a plain number to the ports. > > Also, [ x != x${BUILD_FAIL_MESSAGE} ] thing seems to be a bit unsafe, > > and inconsistent to IGNORE/BROKEN/... vars, in which we don't use > > quotes. > > It's consistent with CONFIGURE_FAIL_MESSAGE. Why are you removing the > parenthesis around the ${ECHO_CMD} ${BUILD_FAIL_MESSAGE}, BTW? > Because they are present in do-configure target too - should they be > removed there too? I just didn't like them :) Are they really needed around single command? -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru