From owner-freebsd-current@FreeBSD.ORG Thu Jul 29 16:33:19 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 85E751065717; Thu, 29 Jul 2010 16:33:19 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id 17AE28FC0C; Thu, 29 Jul 2010 16:33:17 +0000 (UTC) Received: by gxk24 with SMTP id 24so238927gxk.13 for ; Thu, 29 Jul 2010 09:33:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=GqPtYVg6ZNiysDmhiaPrWZ68Gp2iVKuPqIYMmJDrW4k=; b=LQmLgUlNDdA2zR4xEyAUptIFpzWOlTGW0eloIHeTDZjJxsK6VZVJP/MKALfRCgoPQ7 JpD0g31JHEjYhmPP+gPJJYwtcjjPuV2WnzWUj3y4t2p6yKeC6Vyq6kxeh1Xr/+XjLu6n lt7M9UxMKXMrvI2jivw7t2hILcSfo65ZlOeMs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=GSf/I4bijy+WBkKz3Hy40WQ2ekd99lMnBBrfPzydwQONCFPN1pyfQHJwCbrdS4MUhT XY6Uo73tal94sPjgIeHLrjMI8pX/5/CiJo/TT/pteKLI6PiAT+10jN40OT0w4mweKUXL Vy3yDiGEWUzhKztaHE8Saon3cgII2ZamwoAjg= MIME-Version: 1.0 Received: by 10.150.53.21 with SMTP id b21mr1523290yba.75.1280421197245; Thu, 29 Jul 2010 09:33:17 -0700 (PDT) Sender: mdf356@gmail.com Received: by 10.42.6.85 with HTTP; Thu, 29 Jul 2010 09:33:17 -0700 (PDT) In-Reply-To: <201007291018.07112.jhb@freebsd.org> References: <201007291018.07112.jhb@freebsd.org> Date: Thu, 29 Jul 2010 09:33:17 -0700 X-Google-Sender-Auth: dvoyJmIKXhd6va-IwDnlPHsC0dU Message-ID: From: mdf@FreeBSD.org To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org Subject: Re: Panic booting vmware i386 after SRAT update X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jul 2010 16:33:19 -0000 On Thu, Jul 29, 2010 at 7:18 AM, John Baldwin wrote: > On Wednesday, July 28, 2010 1:37:42 pm mdf@freebsd.org wrote: >> I have a 2 cpu virtual image of FreeBSD current. =A0It panics during >> boot after building in the NUMA support. >> >> I'll transcribe the SRAT bootverbose messages and panic message as best = I can. >> >> Table 'SRAT' at 0xfef07f6 >> SRAT: Found table at 0xfef07f6 >> SRAT: Found memory domain 0 addr 0 len a0000: enabled >> SRAT: Found memory domain 0 addr 100000 len ff00000: enabled >> >> then some MADT: messages about finding cpu 0 and 1 >> >> =A0cpu0 (BSP): APIC ID: =A00 >> =A0cpu1 (AP): APIC ID: =A01 >> panic: SRAT: CPU with APIC ID 0 is not known >> >> I'm playing around now with trying to figure out what went missing, >> but I thought I'd send this out now. > > Hmm, check_domains() in srat.c should reject the SRAT table in this case. > Oh, I see the problem, try this: > > Index: srat.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- srat.c =A0 =A0 =A0(revision 210552) > +++ srat.c =A0 =A0 =A0(working copy) > @@ -150,7 +150,8 @@ > =A0 =A0 =A0 =A0for (i =3D 0; i < num_mem; i++) { > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0found =3D 0; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0for (j =3D 0; j <=3D MAX_APIC_ID; j++) > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (cpus[j].domain =3D=3D m= em_info[i].domain) { > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (cpus[j].enabled && > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 cpus[j].domain =3D= =3D mem_info[i].domain) { > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0cpus[j].ha= s_memory =3D 1; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0found++; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0} This appears to fix the issue for me. Thanks, matthew