From owner-svn-src-all@FreeBSD.ORG Sun Jun 12 20:43:20 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B9128106566C; Sun, 12 Jun 2011 20:43:20 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (cl-327.ede-01.nl.sixxs.net [IPv6:2001:7b8:2ff:146::2]) by mx1.freebsd.org (Postfix) with ESMTP id 7CA9D8FC14; Sun, 12 Jun 2011 20:43:20 +0000 (UTC) Received: from [IPv6:2001:7b8:3a7:0:192b:ad96:b84:94cd] (unknown [IPv6:2001:7b8:3a7:0:192b:ad96:b84:94cd]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 657115C59; Sun, 12 Jun 2011 22:43:19 +0200 (CEST) Message-ID: <4DF524E5.6060603@FreeBSD.org> Date: Sun, 12 Jun 2011 22:43:17 +0200 From: Dimitry Andric Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.18pre) Gecko/20110527 Lanikai/3.1.11pre MIME-Version: 1.0 To: Kirk McKusick References: <201106121927.p5CJR5Wi038037@svn.freebsd.org> In-Reply-To: <201106121927.p5CJR5Wi038037@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r223020 - in head/sys/ufs: ffs ufs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Jun 2011 20:43:20 -0000 On 2011-06-12 21:27, Kirk McKusick wrote: > Author: mckusick > Date: Sun Jun 12 19:27:05 2011 > New Revision: 223020 > URL: http://svn.freebsd.org/changeset/base/223020 ... > Modified: head/sys/ufs/ffs/ffs_extern.h > ============================================================================== > --- head/sys/ufs/ffs/ffs_extern.h Sun Jun 12 18:52:39 2011 (r223019) > +++ head/sys/ufs/ffs/ffs_extern.h Sun Jun 12 19:27:05 2011 (r223020) ... > @@ -161,4 +166,14 @@ void softdep_journal_fsync(struct inode > > int ffs_rdonly(struct inode *); > > +TAILQ_HEAD(snaphead, inode); > + > +struct snapdata { > + LIST_ENTRY(snapdata) sn_link; > + struct snaphead sn_head; > + daddr_t sn_listsize; > + daddr_t *sn_blklist; > + struct lock sn_lock; > +}; > + > #endif /* !_UFS_FFS_EXTERN_H */ This addition breaks world compilation in usr.sbin/makefs, apparently because the TAILQ_HEAD macro isn't defined at that point: ... cc -O2 -pipe -I/usr/src/usr.sbin/makefs -I/usr/src/usr.sbin/makefs/../../sys/fs/cd9660/ -I/usr/src/usr.sbin/makefs/../../sys/ufs/ffs -I/usr/src/usr.sbin/makefs/compat -DHAVE_STRUCT_STAT_ST_FLAGS=1 -DHAVE_STRUCT_STAT_ST_GEN=1 -I/usr/src/usr.sbin/makefs/../mtree -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign -c /usr/src/usr.sbin/makefs/ffs/ffs_bswap.c cc1: warnings being treated as errors In file included from /usr/src/usr.sbin/makefs/ffs/ffs_bswap.c:51: /usr/obj/usr/src/tmp/usr/include/ufs/ffs/ffs_extern.h:169: warning: data definition has no type or storage class /usr/obj/usr/src/tmp/usr/include/ufs/ffs/ffs_extern.h:169: warning: parameter names (without types) in function declaration /usr/obj/usr/src/tmp/usr/include/ufs/ffs/ffs_extern.h:172: error: expected specifier-qualifier-list before 'LIST_ENTRY' *** Error code 1 Stop in /usr/src/usr.sbin/makefs.