From owner-cvs-src@FreeBSD.ORG Tue Oct 5 18:18:50 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4F4A016A4CE; Tue, 5 Oct 2004 18:18:50 +0000 (GMT) Received: from www.cryptography.com (li-22.members.linode.com [64.5.53.22]) by mx1.FreeBSD.org (Postfix) with ESMTP id 16BA043D45; Tue, 5 Oct 2004 18:18:50 +0000 (GMT) (envelope-from nate@root.org) Received: from [10.0.0.34] (adsl-67-119-74-222.dsl.sntc01.pacbell.net [67.119.74.222]) by www.cryptography.com (8.12.8/8.12.8) with ESMTP id i95IIEUQ024199 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 5 Oct 2004 11:18:14 -0700 Message-ID: <4162E53A.40100@root.org> Date: Tue, 05 Oct 2004 11:17:30 -0700 From: Nate Lawson User-Agent: Mozilla Thunderbird 0.7.3 (Windows/20040803) X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200410050237.LAA20152@axe-inc.co.jp> <4162DEF0.1020809@root.org> <200410051409.30619.jhb@FreeBSD.org> In-Reply-To: <200410051409.30619.jhb@FreeBSD.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: Takanori Watanabe cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/acpi/acpidump acpi.c acpidump.c acpidump.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2004 18:18:50 -0000 John Baldwin wrote: > On Tuesday 05 October 2004 01:50 pm, Nate Lawson wrote: > >>Takanori Watanabe wrote: >> >>>In message <200410050218.i952IrBK008982@repoman.freebsd.org>, Nate Lawson >>>wrote >>> >>> >>>>njl 2004-10-05 02:18:53 UTC >>>> >>>>FreeBSD src repository >>>> >>>>Modified files: >>>> usr.sbin/acpi/acpidump acpi.c acpidump.c acpidump.h >>>>Log: >>>>Add the -s flag to make dumping SSDTs optional (disabled by default). >>>>Since we can only override the DSDT, a custom ASL dumped previously that >>>>contained SSDTs would result in lots of multiple definition errors. >>>> >>>>A longer-term fix involves adding the ability to override SSDTs to >>>>ACPI-CA. >>> >>>iasl(8) may have to be able to compile multiple AML codes from single >>>ASL data, instead of merging SSDT into DSDT in acpidump(8). >> >>I think the most straightforward fix is for ACPI-CA to not load SSDT >>tables when the user is overriding the DSDT. If you treat overridden >>SSDTs separately, you go down the path of having to specify _which_ >>table you want to override, which implies you need strict ordering of >>tables in both ASL and AML and it just gets too complicated. Some HP >>Itanium machines have 8 to 10 SSDTs. > > > I agree. It makes the user's lives a lot easier if they procedure remains: > > - acpidump > foo.asl > - hack on foo.asl to fix it > - compile foo.asl to foo.dsdt > - load foo.dsdt in the loader > > and have it all just work. Actually, you know, we could make this work on our > own without requiring ACPI-CA to change. You just need to hack > AcpiOsTableOverride() in OsdTable.c to return a pointer to an empty table for > "SSDT" tables when the DSDT is overridden. In fact, I think that is probably > where this behavior decision really belongs. Good idea, I'll look into this. If feasible, I'll commit this and revert the acpidump change. -- Nate