From owner-cvs-all Tue Jun 20 11: 3: 1 2000 Delivered-To: cvs-all@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id 702CB37BCF6; Tue, 20 Jun 2000 11:02:49 -0700 (PDT) (envelope-from des@flood.ping.uio.no) Received: (from des@localhost) by flood.ping.uio.no (8.9.3/8.9.3) id UAA74161; Tue, 20 Jun 2000 20:02:36 +0200 (CEST) (envelope-from des@flood.ping.uio.no) To: "Jordan K. Hubbard" Cc: Wes Peters , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libfetch ftp.c References: <6113.961509871@localhost> From: Dag-Erling Smorgrav Date: 20 Jun 2000 20:02:36 +0200 In-Reply-To: "Jordan K. Hubbard"'s message of "Tue, 20 Jun 2000 07:04:31 -0700" Message-ID: Lines: 21 User-Agent: Gnus/5.0802 (Gnus v5.8.2) Emacs/20.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG "Jordan K. Hubbard" writes: > > Wes Peters writes: > > > Log: > > > Add implementation of fetchListFTP. > > Absolutely not acceptable under any pretext. > You should also say why. It does not foster good relations between > developers when you simply back something out without previous comment > or any explanation as to why it's not acceptable. 1) I am the maintainer of this code, and the README clearly states that although contributions are welcome, no commits should be made without my prior agreement. 2) The patch is unnecessarily bulky and duplicates code found elsewhere in libfetch. I chose to set it aside until I was finished rewriting the HTTP code, which already suffers severely from code duplication. DES -- Dag-Erling Smorgrav - des@flood.ping.uio.no To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message