From owner-p4-projects@FreeBSD.ORG Mon May 3 22:30:08 2010 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 50B241065686; Mon, 3 May 2010 22:30:08 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 148B91065692; Mon, 3 May 2010 22:30:08 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [195.88.108.3]) by mx1.freebsd.org (Postfix) with ESMTP id 6B2248FC13; Mon, 3 May 2010 22:30:07 +0000 (UTC) Received: from localhost (amavis.fra.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 9877141C7A9; Tue, 4 May 2010 00:30:06 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([192.168.74.103]) by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id epgkS+RqqwY1; Tue, 4 May 2010 00:30:06 +0200 (CEST) Received: by mail.cksoft.de (Postfix, from userid 66) id 22A4341C7A8; Tue, 4 May 2010 00:30:06 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id 498BC4448EC; Mon, 3 May 2010 22:25:37 +0000 (UTC) Date: Mon, 3 May 2010 22:25:37 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Marko Zec In-Reply-To: <201005040006.11204.zec@icir.org> Message-ID: <20100503222206.K23815@maildrop.int.zabbadoz.net> References: <201005032103.o43L3nah081080@repoman.freebsd.org> <201005040006.11204.zec@icir.org> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Ana Kukec , Perforce Change Reviews Subject: Re: PERFORCE change 177677 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 May 2010 22:30:08 -0000 On Tue, 4 May 2010, Marko Zec wrote: > On Monday 03 May 2010 23:03:49 Ana Kukec wrote: >> http://p4web.freebsd.org/@@177677?ac=10 >> >> Change 177677 by anchie@anchie_malimis on 2010/05/03 21:03:44 >> >> Getting rid of the global variable V_send_so from files other then >> send.[ch]. > > Just wondering - isn't this change actually increasing the possibility for a > race between packet datapath and send.ko kldloading / kldunloading? I.e. had Yes, but it simplifies locking which is to come once the rest is correct; as you have figured, you cannot do it lock-free anyway in the module case ("pfil problem"). > Also, if I'm not mistaking, even if send_sendso_input() returns an error, it > will have the mbuf consumed / freed, so any further attempts to do anything > with the mbuf will crash the system. Do we really want to do m_freem(m) at > the bottom of send_sendso_input()? No we don't. Well not in the case there is no socket. Ana knows already but having this checkpointed in p4 helped me to see where we were;) /bz -- Bjoern A. Zeeb See you when I see you.