From nobody Wed Nov 1 02:47:54 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SKrz261rzz4yZdm; Wed, 1 Nov 2023 02:47:58 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta001.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SKrz20trYz4NqN; Wed, 1 Nov 2023 02:47:58 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4002a.ext.cloudfilter.net ([10.228.9.250]) by cmsmtp with ESMTPS id xpuiqPwiz8jpTy1GuqzR8R; Wed, 01 Nov 2023 02:47:57 +0000 Received: from spqr.komquats.com ([70.66.152.170]) by cmsmtp with ESMTPSA id y1Gtq9IqpnCF0y1Guq9RjQ; Wed, 01 Nov 2023 02:47:56 +0000 X-Authority-Analysis: v=2.4 cv=MPFzJeVl c=1 sm=1 tr=0 ts=6541bc5c a=y8EK/9tc/U6QY+pUhnbtgQ==:117 a=y8EK/9tc/U6QY+pUhnbtgQ==:17 a=kj9zAlcOel0A:10 a=bhdUkHdE2iEA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=5mwuUaf1-w-P0o8vk6MA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id E4600C41; Tue, 31 Oct 2023 19:47:54 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id B8B0A40F; Tue, 31 Oct 2023 19:47:54 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Warner Losh cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 0527c9bdc718 - main - ino64: Remove 'forward compat' code for this In-reply-to: <202310312127.39VLReES081354@gitrepo.freebsd.org> References: <202310312127.39VLReES081354@gitrepo.freebsd.org> Comments: In-reply-to Warner Losh message dated "Tue, 31 Oct 2023 21:27:40 +0000." List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 31 Oct 2023 19:47:54 -0700 Message-Id: <20231101024754.B8B0A40F@slippy.cwsent.com> X-CMAE-Envelope: MS4xfMv0fAt/eBqWAAfnERNIPed7xLhPTifTua5Qu7Hcy66ZmGdN+jzKpSnOlMQtTN5VXxnuFGsJ45iKpiftgYRzKlG41vs2R7h6flj0Bl+oRviNsZKO6kVB B08Rezq7huer6lC4D2Y55VrYJGhpCYyDdsswbGKAH11qj4ypKB5nPN3L4/B7EsoGF3D01MMZWLLDSGaGzKmA8+wVth/fK4j79icTgrU6z72A+N+edhMg1xbL 3KfB+3PvRfZtoZ8bri58WNCXjrdpG6CzHYSRRXzc5cYWQSekgIMBMCWVZSEASrTihIFFkqP5xIfTF/ZacJhWl+gT3gpwoXObaRFUKhmKNQw= X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Queue-Id: 4SKrz20trYz4NqN In message <202310312127.39VLReES081354@gitrepo.freebsd.org>, Warner Losh write s: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=0527c9bdc7187a0b92511f021dcdbbac > 84f1c579 > > commit 0527c9bdc7187a0b92511f021dcdbbac84f1c579 > Author: Warner Losh > AuthorDate: 2023-10-31 20:55:58 +0000 > Commit: Warner Losh > CommitDate: 2023-10-31 21:26:44 +0000 > > ino64: Remove 'forward compat' code for this > > Forward compatibility code was added for running newer ino64 binaries on > older kernels as a transition aide. Now that ino64 has been in the tree > 6 years, this code is no longer useful and should have been removed long > ago. Remove it now. Should be no user-visible changes at this point as > all the 'upgrade' scenarios it was intended for are long since past. > > Also need to remove this stuff from rtld since the _foo versions > no longer exist. > > Sponsored by: Netflix > Reviewed by: kib > Differential Revision: https://reviews.freebsd.org/D42382 > --- > UPDATING | 12 ++++ > lib/libc/sys/Makefile.inc | 8 --- > lib/libc/sys/compat-ino64.h | 99 --------------------------- > lib/libc/sys/fstat.c | 51 -------------- > lib/libc/sys/fstatat.c | 47 ------------- > lib/libc/sys/fstatfs.c | 51 -------------- > lib/libc/sys/getdents.c | 7 +- > lib/libc/sys/getdirentries.c | 114 ------------------------------ > -- > lib/libc/sys/getfsstat.c | 62 ----------------- > lib/libc/sys/lstat.c | 13 +--- > lib/libc/sys/stat.c | 13 +--- > lib/libc/sys/statfs.c | 47 ------------- > libexec/rtld-elf/rtld-libc/Makefile.inc | 4 +- > 13 files changed, 21 insertions(+), 507 deletions(-) > > diff --git a/UPDATING b/UPDATING > index 722d7d66acbe..1ee0731742b3 100644 > --- a/UPDATING > +++ b/UPDATING > @@ -27,6 +27,10 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 15.x IS SLOW: > world, or to merely disable the most expensive debugging functionality > at runtime, run "ln -s 'abort:false,junk:false' /etc/malloc.conf".) > > +20231027: > + Forward compatibility (running the new code on old kernels) for the > + "ino64" project have been removed. The need for it has passed long ago. > + > 20231018: > Commit 57ce37f9dcd0 changed the internal KAPI between the > nfscommon and nfscl modules. Both must be rebuilt from sources. > @@ -1573,6 +1577,14 @@ https://lists.freebsd.org/archives/freebsd-current/202 > 1-June/000153.html > Switch back to the BSDL dtc (Device Tree Compiler). Set WITH_GPL_DTC > if you require the GPL compiler. > > +20170619: > + Forward compatibility for the "ino64" project have been committed. This > + will allow most new binaries to run on older kernels in a limited > + fashion. This prevents many of the common foot-shooting actions in the > + upgrade as well as the limited ability to roll back the kernel across > + the ino64 upgrade. Complicated use cases may not work properly, though > + enough simpler ones work to allow recovery in most situations. > + > 20170618: > The internal ABI used for communication between the NFS kernel modules > was changed by r320085, so __FreeBSD_version was bumped to Given the notes above, should we also have a __FreeBSD_version bump? -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0