From owner-freebsd-ports@FreeBSD.ORG Mon Nov 19 04:49:14 2007 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9C53D16A41A for ; Mon, 19 Nov 2007 04:49:14 +0000 (UTC) (envelope-from maho.nakata@gmail.com) Received: from rv-out-0910.google.com (rv-out-0910.google.com [209.85.198.189]) by mx1.freebsd.org (Postfix) with ESMTP id 69BEA13C457 for ; Mon, 19 Nov 2007 04:49:14 +0000 (UTC) (envelope-from maho.nakata@gmail.com) Received: by rv-out-0910.google.com with SMTP id l15so1389727rvb for ; Sun, 18 Nov 2007 20:49:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:date:message-id:to:cc:subject:from:in-reply-to:references:x-mailer:mime-version:content-type:content-transfer-encoding:sender; bh=EKpnmZnIZ7Wyp8qmm5Q3/hVDi+O+S7uehVsyYFC6vCE=; b=QEz14Xo4UiuDDsa+qcu2HxPSiTFpVn8+l+DT9etG9jOyEaR4XO46FCS8G7wWomlYldCcyt4TtaehutXo0PIDImKLAVLgeDS0qwNs7zyxDETV6mB7O1DXMR9ykAioimN1jMygDVS5zAqfWI2j5+U8+zkf45qW9r66FlAIl8Jm5ik= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:message-id:to:cc:subject:from:in-reply-to:references:x-mailer:mime-version:content-type:content-transfer-encoding:sender; b=O7irdIoFXJBQiAo3Mr5fl4aSzwf4Rl0qyb0yk6L4g7A1bsQ6UilGrdzJv5fq5EZYZY+ENZUZPvQYQRA39xPFEASjNbd7WPijcHDZOTmzxwvuD5wLOlBWJ+0k/ix4KMfh2FfNBSgFRT7aEnue9P/KYI1+QQuV++k7unt9iEIeGU8= Received: by 10.140.135.20 with SMTP id i20mr1466337rvd.1195446277181; Sun, 18 Nov 2007 20:24:37 -0800 (PST) Received: from localhost ( [134.160.214.85]) by mx.google.com with ESMTPS id l31sm7229154rvb.2007.11.18.20.24.33 (version=SSLv3 cipher=OTHER); Sun, 18 Nov 2007 20:24:35 -0800 (PST) Date: Mon, 19 Nov 2007 13:24:30 +0900 (JST) Message-Id: <20071119.132430.232757505.chat95@mac.com> To: stephen@math.missouri.edu, portmgr@FreeBSD.org From: Maho NAKATA In-Reply-To: <474106CB.9060700@math.missouri.edu> References: <474106CB.9060700@math.missouri.edu> X-Mailer: Mew version 5.2 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: Maho NAKATA Cc: maho@freeBSD.org, ports@freeBSD.org Subject: Re: octave-forge on FreeBSD 7.0 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2007 04:49:14 -0000 Dear portmgr@ and Stephen Portmgr@: Stephen Montgomery-Smith reported that applying following patch will unbreak for FBSD7. Could you please approve my commit? Index: Makefile =================================================================== RCS file: /home/pcvs/ports/math/octave-forge/Makefile,v retrieving revision 1.19 diff -u -r1.19 Makefile --- Makefile 1 Oct 2007 09:34:23 -0000 1.19 +++ Makefile 19 Nov 2007 04:22:31 -0000 @@ -36,9 +36,7 @@ .include .if ${OSVERSION} >= 700042 -.if ${ARCH} == "amd64" || ${ARCH} == "sparc64" -BROKEN= Does not compile with GCC 4.2 -.endif +USE_GCC= 3.4 .endif GNU_HOST= ${ARCH}-portbld-freebsd${OSREL} cvs diff: Diffing files From: Stephen Montgomery-Smith Subject: octave-forge on FreeBSD 7.0 Date: Sun, 18 Nov 2007 21:45:15 -0600 Stephen: > I noticed that you added lines like: > > .if ${OSVERSION} >= 700042 > .if ${ARCH} == "amd64" || ${ARCH} == "sparc64" > BROKEN= Does not compile with GCC 4.2 > .endif > .endif No, linimon added :) Revision 1.19: download - view: text, markup, annotated - select for diffs Mon Oct 1 09:34:23 2007 UTC (6 weeks, 6 days ago) by linimon Branches: MAIN CVS tags: HEAD Diff to: previous 1.18: preferred, colored Changes since revision 1.18: +4 -2 lines Mark as broken with gcc4.2 on 64-bit archs. While here, remove obsolete cruft. > to the Makefile of math/octave-forge. But it also doesn't build on my > i386 FreeBSD 7.0 machine. :( > How about doing something more simple like: > > .if ${OSVERSION} >= 700042 > USE_GCC= 3.4 > .endif > > which works great in my situation. Thanks for your report. I ask portmgr@ for commit approval. Thanks, -- Nakata Maho (maho@FreeBSD.org)