From owner-freebsd-mips@FreeBSD.ORG Fri Dec 3 07:42:07 2010 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B86491065672 for ; Fri, 3 Dec 2010 07:42:07 +0000 (UTC) (envelope-from c.jayachandran@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 495028FC1E for ; Fri, 3 Dec 2010 07:42:06 +0000 (UTC) Received: by wwf26 with SMTP id 26so4875430wwf.31 for ; Thu, 02 Dec 2010 23:42:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type; bh=5LhOLdwRx3xT+W3TFGk2692S3BKYvZuSJEPntv8Kduw=; b=NygylKp5xZt22qvrmXOYGXnstk3wxybZD96qWB3D6pEzYGVyjWVHMmV4V7o8uH/Nwq E7E/jVMs+xw/EN4bLfhDf3rM04fllYH+BGT/YA81kr017PwPTOAFwjWy6HdLosrK3IyC blEMcd8nhx2V++OQBZmg39JlK/UE1zZv3AqVk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=P9sUfw9cDLFQS9SAXskat7pfdNapdBrS13OZSuJcR631OL/MouMpd0IbGKY7ZDzazr 5FsVomDxlGe8FAX76Rvbdy6YMwTt4n3DCBpWJ+lVNJJMyixeZM4JN7EVM7Ml2T+Rsnlu 4Aeyrx17bXV49trBtwwz4dHbqrQx17klt/9zw= MIME-Version: 1.0 Received: by 10.227.28.100 with SMTP id l36mr1427536wbc.102.1291362126198; Thu, 02 Dec 2010 23:42:06 -0800 (PST) Received: by 10.227.135.84 with HTTP; Thu, 2 Dec 2010 23:42:05 -0800 (PST) In-Reply-To: <4CF7DD6C.6020303@rice.edu> References: <4CF5E518.20508@rice.edu> <4CF71F79.3020500@bsdimp.com> <4CF7DD6C.6020303@rice.edu> Date: Fri, 3 Dec 2010 13:12:05 +0530 Message-ID: From: "Jayachandran C." To: Alan Cox , Warner Losh , freebsd-mips@freebsd.org Content-Type: multipart/mixed; boundary=0022159753aacef86504967cac85 Cc: Subject: Re: vm_page_startup() X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Dec 2010 07:42:07 -0000 --0022159753aacef86504967cac85 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Thu, Dec 2, 2010 at 11:24 PM, Alan Cox wrote: > Warner Losh wrote: >> >> On 11/30/2010 23:03, Alan Cox wrote: >>> >>> Given this bit of code in the MIPS pmap: >>> >>> vm_offset_t >>> pmap_map(vm_offset_t *virt, vm_offset_t start, vm_offset_t end, int pro= t) >>> { >>> =A0 vm_offset_t va, sva; >>> >>> =A0 if (MIPS_DIRECT_MAPPABLE(end)) >>> =A0 =A0 =A0 return (MIPS_PHYS_TO_DIRECT(start)); >> >> All mips architectures have at least a small direct map... > ... > Doesn't the above test have an off-by-error, specifically, shouldn't it b= e > "MIPS_DIRECT_MAPPABLE(end - 1)"? Yes. There was another place where the same error was made. I have attached a patch for these (also cleans up a few comments which I had added some time back). If there are no objections, I will check this in later today. JC. --0022159753aacef86504967cac85 Content-Type: text/x-patch; charset=US-ASCII; name="mips-pmap.patch" Content-Disposition: attachment; filename="mips-pmap.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gh8rqngd0 SW5kZXg6IHN5cy9taXBzL21pcHMvcG1hcC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHN5cy9taXBzL21pcHMv cG1hcC5jCShyZXZpc2lvbiAyMTU5NzQpCisrKyBzeXMvbWlwcy9taXBzL3BtYXAuYwkod29ya2lu ZyBjb3B5KQpAQCAtMTk2LDE0ICsxOTYsMTUgQEAgc3RhdGljIHZvaWQgcG1hcF91cGRhdGVfcGFn ZV9hY3Rpb24odm9pZCAqYXJnKTsKIAogI2lmbmRlZiBfX21pcHNfbjY0CiAvKgotICogVGhpcyBz dHJ1Y3R1cmUgaXMgZm9yIGhpZ2ggbWVtb3J5IChtZW1vcnkgYWJvdmUgNTEyTWVnIGluIDMyIGJp dCkKLSAqIFRoaXMgbWVtb3J5IGFyZWEgZG9lcyBub3QgaGF2ZSBkaXJlY3QgbWFwcGluZywgc28g d2UgYSBtZWNoYW5pc20gdG8gZG8KLSAqIHRlbXBvcmFyeSBwZXItQ1BVIG1hcHBpbmcgdG8gYWNj ZXNzIHRoZXNlIGFkZHJlc3Nlcy4KKyAqIFRoaXMgc3RydWN0dXJlIGlzIGZvciBoaWdoIG1lbW9y eSAobWVtb3J5IGFib3ZlIDUxMk1lZyBpbiAzMiBiaXQpIHN1cHBvcnQuCisgKiBUaGUgaGlnaG1l bSBhcmVhIGRvZXMgbm90IGhhdmUgYSBLU0VHMCBtYXBwaW5nLCBhbmQgd2UgbmVlZCBhIG1lY2hh bmlzbSB0bworICogZG8gdGVtcG9yYXJ5IHBlci1DUFUgbWFwcGluZ3MgZm9yIHBtYXBfemVyb19w YWdlLCBwbWFwX2NvcHlfcGFnZSBldGMuCiAgKgotICogQXQgYm9vdHVwIHdlIHJlc2VydmUgMiB2 aXJ0dWFsIHBhZ2VzIHBlciBDUFUgZm9yIG1hcHBpbmcgaGlnaG1lbSBwYWdlcywgdG8gCi0gKiBh Y2Nlc3MgYSBoaWdobWVtIHBoeXNpY2FsIGFkZHJlc3Mgb24gYSBDUFUsIHdlIHdpbGwgZGlzYWJs ZSBpbnRlcnJ1cHRzIGFuZAotICogYWRkIHRoZSBtYXBwaW5nIGZyb20gdGhlIHJlc2VydmVkIHZp cnR1YWwgYWRkcmVzcyBmb3IgdGhlIENQVSB0byB0aGUgcGh5c2ljYWwKLSAqIGFkZHJlc3MgaW4g dGhlIGtlcm5lbCBwYWdldGFibGUuCisgKiBBdCBib290dXAsIHdlIHJlc2VydmUgMiB2aXJ0dWFs IHBhZ2VzIHBlciBDUFUgZm9yIG1hcHBpbmcgaGlnaG1lbSBwYWdlcy4gVG8gCisgKiBhY2Nlc3Mg YSBoaWdobWVtIHBoeXNpY2FsIGFkZHJlc3Mgb24gYSBDUFUsIHdlIG1hcCB0aGUgcGh5c2ljYWwg YWRkcmVzcyB0bworICogdGhlIHJlc2VydmVkIHZpcnR1YWwgYWRkcmVzcyBmb3IgdGhlIENQVSBp biB0aGUga2VybmVsIHBhZ2V0YWJsZS4gIFRoaXMgaXMgCisgKiBkb25lIHdpdGggaW50ZXJydXB0 cyBkaXNhYmxlZChhbHRob3VnaCBhIHNwaW5sb2NrIGFuZCBzY2hlZF9waW4gd291bGQgYmUgCisg KiBzdWZmaWNpZW50KS4KICAqLwogc3RydWN0IGxvY2FsX3N5c21hcHMgewogCXZtX29mZnNldF90 CWJhc2U7CkBAIC01MjAsMTEgKzUyMSwxMSBAQCBhZ2FpbjoKIAl9CiAKICAgICAgICAJLyoKLQkg KiBJbiAzMiBiaXQsIHdlIG1heSBoYXZlIG1lbW9yeSB3aGljaCBjYW5ub3QgYmUgbWFwcGVkIGRp cmVjdGx5Ci0JICogdGhpcyBtZW1vcnkgd2lsbCBuZWVkIHRlbXBvcmFyeSBtYXBwaW5nIGJlZm9y ZSBpdCBjYW4gYmUKKwkgKiBJbiAzMiBiaXQsIHdlIG1heSBoYXZlIG1lbW9yeSB3aGljaCBjYW5u b3QgYmUgbWFwcGVkIGRpcmVjdGx5LgorCSAqIFRoaXMgbWVtb3J5IHdpbGwgbmVlZCB0ZW1wb3Jh cnkgbWFwcGluZyBiZWZvcmUgaXQgY2FuIGJlCiAJICogYWNjZXNzZWQuCiAJICovCi0JaWYgKCFN SVBTX0RJUkVDVF9NQVBQQUJMRShwaHlzX2F2YWlsW2kgLSAxXSkpCisJaWYgKE1JUFNfRElSRUNU X01BUFBBQkxFKHBoeXNfYXZhaWxbaSAtIDFdIC0gMSkgPT0gMCkKIAkJbmVlZF9sb2NhbF9tYXBw aW5ncyA9IDE7CiAKIAkvKgpAQCAtODkzLDcgKzg5NCw3IEBAIHBtYXBfbWFwKHZtX29mZnNldF90 ICp2aXJ0LCB2bV9vZmZzZXRfdCBzdGFydCwgdm1fCiB7CiAJdm1fb2Zmc2V0X3QgdmEsIHN2YTsK IAotCWlmIChNSVBTX0RJUkVDVF9NQVBQQUJMRShlbmQpKQorCWlmIChNSVBTX0RJUkVDVF9NQVBQ QUJMRShlbmQgLSAxKSkKIAkJcmV0dXJuIChNSVBTX1BIWVNfVE9fRElSRUNUKHN0YXJ0KSk7CiAK IAl2YSA9IHN2YSA9ICp2aXJ0Owo= --0022159753aacef86504967cac85--