From owner-freebsd-embedded@FreeBSD.ORG  Thu Jul  4 17:42:51 2013
Return-Path: <owner-freebsd-embedded@FreeBSD.ORG>
Delivered-To: freebsd-embedded@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id A3369298
 for <freebsd-embedded@freebsd.org>; Thu,  4 Jul 2013 17:42:51 +0000 (UTC)
 (envelope-from freebsd_arm@myspectrum.nl)
Received: from mail.virtualhost.nl (mail.virtualhost.nl [89.200.201.133])
 by mx1.freebsd.org (Postfix) with ESMTP id F1AE01362
 for <freebsd-embedded@freebsd.org>; Thu,  4 Jul 2013 17:42:50 +0000 (UTC)
Received: (qmail 67420 invoked by uid 1141); 4 Jul 2013 19:42:42 +0200
Received: from ip120-12-208-87.adsl2.static.versatel.nl (HELO [10.0.0.15])
 (87.208.12.120)
 (smtp-auth username freebsd_arm@myspectrum.nl, mechanism plain)
 by mail.virtualhost.nl (qpsmtpd/0.84) with (CAMELLIA256-SHA encrypted) ESMTPSA;
 Thu, 04 Jul 2013 19:42:42 +0200
Message-ID: <51D5B41A.5000805@myspectrum.nl>
Date: Thu, 04 Jul 2013 19:42:50 +0200
From: Jeroen Hofstee <freebsd_arm@myspectrum.nl>
User-Agent: Mozilla/5.0 (X11; Linux i686;
 rv:17.0) Gecko/20130623 Thunderbird/17.0.7
MIME-Version: 1.0
To: Warner Losh <imp@bsdimp.com>
Subject: Re: [PATCH] SDIO support for Globalscale Dreamplug
References: <20130702145905.GA1847@olymp.kibab.com>
 <51D3097A.8010601@FreeBSD.org> <51D3282C.1090701@bakulin.de>
 <C92CE8E1-75A0-459F-95DA-956D03DCB2E2@bsdimp.com>
 <20130703222002.GA60491@olymp.kibab.com> <51D50C55.1040300@myspectrum.nl>
 <16DEBC38-F99A-4733-86FD-9E81A146CE5C@bsdimp.com>
In-Reply-To: <16DEBC38-F99A-4733-86FD-9E81A146CE5C@bsdimp.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Alexander Motin <mav@FreeBSD.org>, Ilya Bakulin <ilya@bakulin.de>,
 freebsd-arm@freebsd.org, freebsd-embedded@freebsd.org
X-BeenThere: freebsd-embedded@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Dedicated and Embedded Systems <freebsd-embedded.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-embedded>, 
 <mailto:freebsd-embedded-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-embedded>
List-Post: <mailto:freebsd-embedded@freebsd.org>
List-Help: <mailto:freebsd-embedded-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-embedded>, 
 <mailto:freebsd-embedded-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Jul 2013 17:42:51 -0000

Hello Warner,

On 07/04/2013 06:09 PM, Warner Losh wrote:
> On Jul 3, 2013, at 11:47 PM, Jeroen Hofstee wrote:
>
>> Hello Ilya,
>>
>> On 07/04/2013 12:20 AM, Ilya Bakulin wrote:
>>> So some bytes lack 0x40... This problem occurs also with other numbers
>>> read from the card, for example, vendor ID is read as 0x029F instead of 0x02DF.
>>> +/* Halfword bit masks used for command response extraction. */
>>> +#define MV_SDIO_RSP48_BM2	0x0002	/* Lower 2 bits. */
>>> +#define MV_SDIO_RSP48_BM6	0x003f	/* Lower 6 bits. */
>>> +	/* Response bits [15:14] and [13:8] */
>>> +	*rp++ = (resp[2] & MV_SDIO_RSP48_BM6) |
>>> +	    ((word & MV_SDIO_RSP48_BM2) << 6);
>>> +
>>  From the looks if it, MV_SDIO_RSP48_BM2 must be 3 instead 2.
> And 0x0031 doesn't look right either... I'd have expected 0x3f.
which 0x0031 (perhaps I need to have my eyes checked....)?

Regards,
Jeroen