From nobody Tue May 13 02:28:59 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZxL580pTHz5wBRq; Tue, 13 May 2025 02:29:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZxL576ZQDz4FRT; Tue, 13 May 2025 02:28:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747103339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fziKr5E6zt/F1fjqdIpuWzzEf05KZQzlQfrykulk+tg=; b=HrrrGes+P71hQb1PWTmDaZUHBOtbGtaKi//RWuHYgXsubRppdkeQbKOjR8swnxxgw3zGom 3GuWfddigm1S5G/stxSo/4lQ9UPIuhRTo+5gqSs+kHBs4IjdstffMR9ZxbHApoO5jvQzRY rtI3GDornp8OZcOZfVGnhuOkW1YrFqYMsO2KFQIeFt0yHta7AZK5wpPxB1K+w6bc3fi44s VVDxN7bftdrOtaMgQPn0ycSg5yc2d3+3l4a48niksbrVdtAGdU7Hy9CTInThEC/Xnwcit4 lGfvHmUWsp+DUUrC2iMxJFRK0wNeOCrpn119TT3X0987HjCnTYge1xDM5jDk8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747103339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fziKr5E6zt/F1fjqdIpuWzzEf05KZQzlQfrykulk+tg=; b=U1klrzHivmnMtrfmv7bOvuC2MgIJ0evtRn+jvSWoj6T0X4l1CpdLlr9QYt3u0zPeNenMOg ihCh/JPA6sF9VnIk3mv7hCeoVqPUSYQabISQSG+JLgAHTwjqlDXcgy8MKDYsJPbrZaFRMW W+fUL8I2hcVVa7WqM0iSkZkZVQUuhzEVQQMx/lDStIkrvX4T9yJ0YklxoppD9mUvHols7D VA8uZnF9aRfdQcY2s2DnaIy3SGW4bm5DCKdZ1DcgnClVyPD1GFlLpQtSPS4MhlB/PYoj8y vo2uak/fiOvHX0PkFVRvKvG5G1hfmAT5Z5ztkAe7LToAUR6cjOkIl0H2m3TvNg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1747103339; a=rsa-sha256; cv=none; b=WDHTQM7SiPnMph6j9Dv/ZiNR0Xbznud26Z13oeuJSRmgWpi+cTm8I/bjEeeaeb0l3L1WYS 53t+7/vHC1qySZN4rq4xXlROk0S/l55BPzXaoKIX+x/LmU9G7b4hiWMLSxmnVpJJ2A9hVs RYwQnyp6tnu+Up4HzkbTcYP4zEuw2pxV7Z+pu6AyhBeSQ5ieaZ3yykYBQmEIwUx6NLsFZ9 W/9v+qO6+0LNlVTa/qFfLZl4dSegpBS1sXamJoFufaFk8raFzG6YyzAZOMansfcvptJYXM 9YCqfzoMj68Qv8SBQcrG/elmzH3KUTmxMc8X+0xreVodTU7gYl01J1LFolmorg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZxL5767rHzBj1; Tue, 13 May 2025 02:28:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 54D2Sx3U009538; Tue, 13 May 2025 02:28:59 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 54D2Sxfb009535; Tue, 13 May 2025 02:28:59 GMT (envelope-from git) Date: Tue, 13 May 2025 02:28:59 GMT Message-Id: <202505130228.54D2Sxfb009535@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Justin Hibbits Subject: git: c4921a0faaf1 - main - powerpc: Always use BE tag in nexus_map_resource List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhibbits X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: c4921a0faaf1683f39347dd066000d929c39c8b9 Auto-Submitted: auto-generated The branch main has been updated by jhibbits: URL: https://cgit.FreeBSD.org/src/commit/?id=c4921a0faaf1683f39347dd066000d929c39c8b9 commit c4921a0faaf1683f39347dd066000d929c39c8b9 Author: Justin Hibbits AuthorDate: 2025-05-13 01:35:14 +0000 Commit: Justin Hibbits CommitDate: 2025-05-13 01:35:14 +0000 powerpc: Always use BE tag in nexus_map_resource 7b5a5e4e replaced nexus_activate_resource() with the bus generic equivalent, which uses bus_map_resource(). However, though not intended to have a functional change, nexus_map_resource() uses the bus tag of the build (BE vs LE), while nexus_activate_resource() always explicitly set a big-endian tag, leading to failures on powerpc64le now. Using BE unless otherwise explicitly specified with the RF_LITTLEENDIAN fixes LE on bare metal, and doesn't hurt in a VM, which nexus_map_resource() was added for. Reported by: pkubaj Tested by: pkubaj Fixes: 7b5a5e4e("powerpc nexus: Use bus_generic_rman_*") MFC after: 1 day --- sys/powerpc/powerpc/nexus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/powerpc/powerpc/nexus.c b/sys/powerpc/powerpc/nexus.c index 18b8fc57114f..029b6ef8a479 100644 --- a/sys/powerpc/powerpc/nexus.c +++ b/sys/powerpc/powerpc/nexus.c @@ -288,7 +288,7 @@ nexus_map_resource(device_t bus, device_t child, struct resource *r, if ((rman_get_flags(r) & RF_LITTLEENDIAN) != 0) map->r_bustag = &bs_le_tag; else - map->r_bustag = nexus_get_bus_tag(NULL, NULL); + map->r_bustag = &bs_be_tag; map->r_size = length; map->r_bushandle = (bus_space_handle_t)map->r_vaddr; break;