From owner-cvs-all Mon Dec 9 12:49: 0 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3853237B401; Mon, 9 Dec 2002 12:48:59 -0800 (PST) Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by mx1.FreeBSD.org (Postfix) with SMTP id 9945C43F1C; Mon, 9 Dec 2002 12:48:57 -0800 (PST) (envelope-from iedowse@maths.tcd.ie) Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP id ; 9 Dec 2002 20:48:56 +0000 (GMT) To: Josef Karthauser Cc: Nate Lawson , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb ohci.c In-Reply-To: Your message of "Mon, 09 Dec 2002 20:21:03 GMT." <20021209202103.GA658@genius.tao.org.uk> Date: Mon, 09 Dec 2002 20:48:55 +0000 From: Ian Dowse Message-ID: <200212092048.aa11342@salmon.maths.tcd.ie> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20021209202103.GA658@genius.tao.org.uk>, Josef Karthauser writes: >On Mon, Dec 09, 2002 at 11:58:09AM -0800, Nate Lawson wrote: >> On Sun, 8 Dec 2002, Josef Karthauser wrote: >> > MFNetBSD: (partial 1.133) >> > - In ohci_close_pipe, wait 1ms after removing an ED to avoid possible >> > race >> > condition. >> > Approved by: re (rwatson) >> >> Wouldn't it be better to use a mtx or tsleep/wakeup? A delay leaves the >> race, only making it non-deterministic. >Probably, got a patch :)? I haven't looked at the code, but I suspect it is to avoid a race with the USB hardware, since each usb frame lasts for 1ms. Ian To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message