From owner-freebsd-hackers@freebsd.org  Fri Nov  3 03:50:11 2017
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id E3A1BE6AEE4;
 Fri,  3 Nov 2017 03:50:11 +0000 (UTC)
 (envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu
 [128.95.76.21])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "troutmask", Issuer "troutmask" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id B489F762AF;
 Fri,  3 Nov 2017 03:50:11 +0000 (UTC)
 (envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (localhost [127.0.0.1])
 by troutmask.apl.washington.edu (8.15.2/8.15.2) with ESMTPS id vA33oA8A089328
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Thu, 2 Nov 2017 20:50:10 -0700 (PDT)
 (envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)
 by troutmask.apl.washington.edu (8.15.2/8.15.2/Submit) id vA33oABE089327;
 Thu, 2 Nov 2017 20:50:10 -0700 (PDT) (envelope-from sgk)
Date: Thu, 2 Nov 2017 20:50:10 -0700
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Bryan Drewery <bdrewery@FreeBSD.org>
Cc: FreeBSD Toolchain <freebsd-toolchain@freebsd.org>,
 freebsd-hackers <freebsd-hackers@freebsd.org>,
 FreeBSD Current <freebsd-current@freebsd.org>
Subject: Re: Head build unsafe for /etc today
Message-ID: <20171103035010.GA89291@troutmask.apl.washington.edu>
Reply-To: sgk@troutmask.apl.washington.edu
References: <3045EEBF-09E6-4209-B54F-2F95394DBA82@FreeBSD.org>
 <20171103014907.GA88522@troutmask.apl.washington.edu>
 <68BECDA4-C182-436E-854C-C3B19ABB4373@FreeBSD.org>
 <20171103022327.GA88659@troutmask.apl.washington.edu>
 <998FF503-D4B0-4AD5-AD55-98680E4D66CA@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <998FF503-D4B0-4AD5-AD55-98680E4D66CA@FreeBSD.org>
User-Agent: Mutt/1.7.2 (2016-11-26)
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 03 Nov 2017 03:50:12 -0000

On Thu, Nov 02, 2017 at 07:41:21PM -0700, Bryan Drewery wrote:
> 
> Are you accusing me of lying?
> 

Nope.  I'm stating the obvious.  If you are using
META_MODE and you do "make buildwould" that is 
equivalent to "make -DNO_CLEAN buildworld", which
means you did not rebuild the *world*. 

When I see a commit message of the form (and I've
haven't seen one like this in 25+ years of using
FreeBSD (aka 386BSD+patchkit))

Author: bdrewery
Date: Thu Nov  2 22:23:00 2017
New Revision: 325347
URL: https://svnweb.freebsd.org/changeset/base/325347

Log:
  Something is very wrong

Modified:
  head/Makefile

Modified: head/Makefile
==============================================================================
--- head/Makefile	Thu Nov  2 21:58:18 2017	(r325346)
+++ head/Makefile	Thu Nov  2 22:23:00 2017	(r325347)
@@ -1,3 +1,4 @@
+.error Bad revision, please wait for a fix in head

It suggests that whomever did the commit did not properly test
the patch.  The use of META_MODE (or any other shortcut) when
testing simply isn't proper testing.

-- 
Steve