From owner-svn-src-head@freebsd.org Sun Mar 4 10:05:00 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB87BF477E3 for ; Sun, 4 Mar 2018 10:05:00 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yw0-x236.google.com (mail-yw0-x236.google.com [IPv6:2607:f8b0:4002:c05::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 619A97414E for ; Sun, 4 Mar 2018 10:05:00 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yw0-x236.google.com with SMTP id j143so4744155ywb.4 for ; Sun, 04 Mar 2018 02:05:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=YNYFaCvQGnbJxr+MkDggA9F+WTjeXdvXgcbR88MFMk8=; b=QSF6b8MUbvwsRsMMQ3rN3zkyOZWmogurPmslRvf1VKeFPmIHGriyhBzYPiSje3FNMO SG8cmVx2WqRmdEGXyE6sKorDqA9xARCckuHA3F+MFVP6ycO4mQyBnKi22JAKo6CBo+Ek 7k5pfyXowrsqcjEztO4WXKNjW58/6HWsvgtQg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=YNYFaCvQGnbJxr+MkDggA9F+WTjeXdvXgcbR88MFMk8=; b=Uet09VptQBahG/g4hOnXE2qutFs2mr7uXmg8H0qz2DDTp3cEdD40Q48AEBmi6cPNM2 2VdyOitULRi1mBvufb8gC4pq5d39qWCYceRGRj8led8dePEHZg+tf+3npwdnglG4CVvv aqTsGtqP0+f31v4wG3Jv3G2gAKIMBa3Qk4zKbXuByLGAGz/fGU1jHwf9v+0XxmxwlI8b VLx1V1dozI/eG+ObhG1zpBJR6jrIGM+mQjTG3FBZKCFIHC4yB8qY8SnjaLUmK+E2D29X RwvU+Y+nPxlUNuxqGWwFingse5FrE22zfSJyYfdFvvzOadKw4szUTiMuMbTsNnzEDuBw mDPQ== X-Gm-Message-State: APf1xPB2zmOswddvrSozjgqLEyCGGv/JXMpxdewXokQJtyJa+dFcwBPE AXTxCIAj1NiVFQQdTu7fehX0vQjau7iA9nT4cV86Nw== X-Google-Smtp-Source: AG47ELv62xTlycN9PmSC955eRRCARDgZ5S10l/0D3lAndWjhbYfhqNgR6WKDA3qP2p7Epm7Pd8wfpGK3V6gzYHFamCI= X-Received: by 10.129.109.1 with SMTP id i1mr7104543ywc.113.1520157899662; Sun, 04 Mar 2018 02:04:59 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a25:23d2:0:0:0:0:0 with HTTP; Sun, 4 Mar 2018 02:04:29 -0800 (PST) In-Reply-To: <201707022100.v62L0Ume001253@repo.freebsd.org> References: <201707022100.v62L0Ume001253@repo.freebsd.org> From: Eitan Adler Date: Sun, 4 Mar 2018 02:04:29 -0800 Message-ID: Subject: Re: svn commit: r320579 - head/usr.bin/patch To: "Pedro F. Giffuni" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Mar 2018 10:05:01 -0000 On 2 July 2017 at 14:00, Pedro F. Giffuni wrote: > + } else if (strnEQ(s, "diff --git a/", 13)) { > + /* Git-style diffs. */ > + piece_of_git = 1; This is incomplete and leaves to confusing behavior for some git diffs. In particular with 'diff.mnemonicprefix = true' the prefix is awesome something other than 'a/'. It can be 'w' for working copy, 'i' for index, 'c' for commit, or some other values. While I don't oppose this feature, it'd be better if we did not tie it to a single specific prefix. -- Eitan Adler