From owner-freebsd-ports@FreeBSD.ORG Thu Jan 24 13:27:44 2013 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 807D199 for ; Thu, 24 Jan 2013 13:27:44 +0000 (UTC) (envelope-from des@des.no) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id 2746A824 for ; Thu, 24 Jan 2013 13:27:43 +0000 (UTC) Received: from ds4.des.no (smtp.des.no [194.63.250.102]) by smtp-int.des.no (Postfix) with ESMTP id E0A2C6C4E; Thu, 24 Jan 2013 13:27:42 +0000 (UTC) Received: by ds4.des.no (Postfix, from userid 1001) id 92F1BA3AA; Thu, 24 Jan 2013 14:27:42 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Michael Gmelin Subject: Re: Using bidirectional authentication in pkgng References: <20130118035721.283135fb@bsd64.grem.de> <50F9B6CC.3040303@infracaninophile.co.uk> <20130122193035.4c51be04@bsd64.grem.de> <20130123004147.GG27275@ithaqua.etoilebsd.net> <86d2wuvrjg.fsf@ds4.des.no> <20130124121942.07436be3@bsd64.grem.de> Date: Thu, 24 Jan 2013 14:27:42 +0100 In-Reply-To: <20130124121942.07436be3@bsd64.grem.de> (Michael Gmelin's message of "Thu, 24 Jan 2013 12:19:42 +0100") Message-ID: <86r4lau2wh.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jan 2013 13:27:44 -0000 Michael Gmelin writes: > Would be great if you could point out the exact issues, so I could avoid > them next time (I spent literally hours trying to clean up the code so > it complies to style(9), even though it doesn't seem like fetch really > follows it either). Other people's coding standards are always arbitrary > and, um, wrong anyway, you know ;) libfetch follows style(9) very closely, except in some parts of http.c which are too deeply nested. Just a quick summary of issues with your patch: - There are many instances of misplaced opening / closing braces. - Several lines are too long, and almost all your continuation lines are misindented. - There are many instances of missing whitespace around operators in expressions. - You declare variables inside blocks, and declarations in general are not properly sorted. There are issues with the man page as well - you didn't bump the date, sentences don't begin on new lines, and some lines are too long - but you get a million bonus points for updating it at all. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no