From nobody Mon Jun  9 11:49:02 2025
X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bG9F90F4gz5y1QQ;
	Mon, 09 Jun 2025 11:49:17 +0000 (UTC)
	(envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(Client did not present a certificate)
	by mx1.freebsd.org (Postfix) with ESMTPS id 4bG9F841Mjz3VK0;
	Mon, 09 Jun 2025 11:49:16 +0000 (UTC)
	(envelope-from kostikbel@gmail.com)
Authentication-Results: mx1.freebsd.org;
	none
Received: from tom.home (kib@localhost [127.0.0.1] (may be forged))
	by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 559Bn3HT087169;
	Mon, 9 Jun 2025 14:49:06 +0300 (EEST)
	(envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 559Bn3HT087169
Received: (from kostik@localhost)
	by tom.home (8.18.1/8.18.1/Submit) id 559Bn22P087168;
	Mon, 9 Jun 2025 14:49:02 +0300 (EEST)
	(envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f
Date: Mon, 9 Jun 2025 14:49:02 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Dag-Erling =?utf-8?B?U23DuHJncmF2?= <des@freebsd.org>
Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org,
        dev-commits-src-main@freebsd.org
Subject: Re: git: 79d0f4474653 - main - rpcbind: Ensure krpc is present.
Message-ID: <aEbKLniIuHd4xuq7@kib.kiev.ua>
References: <202506091053.559ArJ8k043104@gitrepo.freebsd.org>
List-Id: Commit messages for all branches of the src repository <dev-commits-src-all.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all
List-Help: <mailto:dev-commits-src-all+help@freebsd.org>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Subscribe: <mailto:dev-commits-src-all+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-src-all+unsubscribe@freebsd.org>
X-BeenThere: dev-commits-src-all@freebsd.org
Sender: owner-dev-commits-src-all@FreeBSD.org
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202506091053.559ArJ8k043104@gitrepo.freebsd.org>
X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
	DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM,
	NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.1
X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home
X-Rspamd-Queue-Id: 4bG9F841Mjz3VK0
X-Spamd-Bar: ----
X-Rspamd-Pre-Result: action=no action;
	module=replies;
	Message is reply to one we originated
X-Spamd-Result: default: False [-4.00 / 15.00];
	REPLY(-4.00)[];
	ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]

On Mon, Jun 09, 2025 at 10:53:19AM +0000, Dag-Erling Smørgrav wrote:
> The branch main has been updated by des:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=79d0f447465394fee8afa833dbdeb1a5f3ed52c3
> 
> commit 79d0f447465394fee8afa833dbdeb1a5f3ed52c3
> Author:     Dag-Erling Smørgrav <des@FreeBSD.org>
> AuthorDate: 2025-06-09 10:52:21 +0000
> Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
> CommitDate: 2025-06-09 10:52:21 +0000
> 
>     rpcbind: Ensure krpc is present.
>     
>     MFC after:      1 week
>     Reviewed by:    rmacklem, glebius
>     Differential Revision:  https://reviews.freebsd.org/D50627
> ---
>  usr.sbin/rpcbind/rpcbind.c | 35 +++++++++++++++++++++--------------
>  1 file changed, 21 insertions(+), 14 deletions(-)
> 
> diff --git a/usr.sbin/rpcbind/rpcbind.c b/usr.sbin/rpcbind/rpcbind.c
> index 1397a0222396..622e954f903b 100644
> --- a/usr.sbin/rpcbind/rpcbind.c
> +++ b/usr.sbin/rpcbind/rpcbind.c
> @@ -39,34 +39,38 @@
>   *
>   */
>  
> -#include <sys/types.h>
> -#include <sys/stat.h>
> -#include <sys/errno.h>
> -#include <sys/time.h>
> +#include <sys/param.h>
> +#include <sys/linker.h>
> +#include <sys/module.h>
>  #include <sys/resource.h>
> -#include <sys/wait.h>
>  #include <sys/signal.h>
>  #include <sys/socket.h>
> +#include <sys/stat.h>
> +#include <sys/time.h>
>  #include <sys/un.h>
> +#include <sys/wait.h>
> +
>  #include <rpc/rpc.h>
>  #include <rpc/rpc_com.h>
>  #ifdef PORTMAP
>  #include <netinet/in.h>
>  #endif
>  #include <arpa/inet.h>
> +
>  #include <assert.h>
> +#include <err.h>
> +#include <errno.h>
>  #include <fcntl.h>
> +#include <netconfig.h>
>  #include <netdb.h>
> +#include <pwd.h>
>  #include <stdbool.h>
>  #include <stdio.h>
> -#include <netconfig.h>
>  #include <stdlib.h>
> -#include <unistd.h>
> -#include <syslog.h>
> -#include <err.h>
> -#include <pwd.h>
>  #include <string.h>
> -#include <errno.h>
> +#include <syslog.h>
> +#include <unistd.h>
> +
>  #include "rpcbind.h"
>  
>  /* Global variables */
> @@ -148,12 +152,15 @@ main(int argc, char *argv[])
>  
>  	update_bound_sa();
>  
> +	/* Ensure krpc is loaded */
> +	if (modfind("krpc") < 0 && kldload("krpc") < 0)
> +		err(1, "krpc");
Why does rpcbind need krpc mod?
I understand that today most uses of Sun RPC are coming from nfs stuff.
But it is still not the only application.  E.g., NIS is still there.