From owner-svn-src-head@FreeBSD.ORG  Mon Oct 27 17:09:07 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 8410A610;
 Mon, 27 Oct 2014 17:09:07 +0000 (UTC)
Received: from mho-01-ewr.mailhop.org (mho-03-ewr.mailhop.org [204.13.248.66])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5532A3DA;
 Mon, 27 Oct 2014 17:09:07 +0000 (UTC)
Received: from [73.34.117.227] (helo=ilsoft.org)
 by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256)
 (Exim 4.72) (envelope-from <ian@FreeBSD.org>)
 id 1Xinmu-0004rw-CX; Mon, 27 Oct 2014 17:09:00 +0000
Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240])
 by ilsoft.org (8.14.9/8.14.9) with ESMTP id s9RH8wDG076686;
 Mon, 27 Oct 2014 11:08:58 -0600 (MDT) (envelope-from ian@FreeBSD.org)
X-Mail-Handler: Dyn Standard SMTP by Dyn
X-Originating-IP: 73.34.117.227
X-Report-Abuse-To: abuse@dyndns.com (see
 http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse
 reporting information)
X-MHO-User: U2FsdGVkX19mYJ9lmhv2zfGI9hyqnGQS
X-Authentication-Warning: paranoia.hippie.lan: Host revolution.hippie.lan
 [172.22.42.240] claimed to be [172.22.42.240]
Subject: Re: svn commit: r273734 - head/bin/dd
From: Ian Lepore <ian@FreeBSD.org>
To: Kurt Jaeger <pi@FreeBSD.org>
In-Reply-To: <20141027162034.GN1492@f10.opsec.eu>
References: <201410271138.s9RBcHrA002447@svn.freebsd.org>
 <20141028005225.S2013@besplex.bde.org> <20141027162034.GN1492@f10.opsec.eu>
Content-Type: text/plain; charset="us-ascii"
Date: Mon, 27 Oct 2014 11:08:58 -0600
Message-ID: <1414429738.17308.9.camel@revolution.hippie.lan>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port 
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, Bruce Evans <brde@optusnet.com.au>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Oct 2014 17:09:07 -0000

On Mon, 2014-10-27 at 17:20 +0100, Kurt Jaeger wrote:
> Hi!
> 
> > > Log:
> > >  bin/dd: Fix incorrect casting of arguments
> [...]
> > Both of these work correctly in my version (with a relatively small patch
> > and no breakage of other cases).  (I actually typed large values as -1
> > and 11111111111111111111111111.  -1 means (uintmax_t)-1 although this
> > is undocumented and now broken).
> 
> So, given this detailed review, should I revert the change ?
> 

Given that it breaks the build for 32 bit architectures, it probably
should be reverted until a different set of changes is available.

-- Ian