From owner-svn-src-head@freebsd.org Mon Jan 8 21:09:49 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ED4F4E626E9; Mon, 8 Jan 2018 21:09:49 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f41.google.com (mail-it0-f41.google.com [209.85.214.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BC10174D9B; Mon, 8 Jan 2018 21:09:49 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f41.google.com with SMTP id b77so5905020itd.0; Mon, 08 Jan 2018 13:09:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=UtIY/7oD1qfTcaZMU3aWih/Uu4InNUC3exw7PTOwpnQ=; b=qAvwdIZEtEhL9iiTFMrFtmvWQbbwI3mtle0x0qA65Ba1QePRJbmNB08aVV1C206Oxc BNlsrI3EW3jg5roOfgr6aQLbaaTQ71P35zVGYs+4FME+1zWM7pGOBn+2wWh78n46tkMt 50gQMTke1fDtDzPXbCrNod88EpWh43Z/ZoR+0xYu5VyDuCmLJ2BWsOKyZ8s52Bi50YgS 8sXLgRmN+JrMBebd3oMJIMR3r2Mf1Lc9sf067m8EePYJs3Bc/tmza+avtDoo+nZrZ14P sLH/cbhiZla+RatSvigWR6n93/+xRav+jbVPYUozBD+ElRCFqgXRvE/Qp1ht2XIdGHCi Rs8Q== X-Gm-Message-State: AKwxytdsIFRj0liZ3vbr0IYxDp5WjQcuneogYZeHNzJm0UlwWe0cL1cm WzSxUDks1QB3oD3OUj5SX1U89A0h X-Google-Smtp-Source: ACJfBouR3Tu89hnY0HZEL8oFEpdzsp/9/VjihhrDtlh7MXGqS1Tj1FlyS7tYT6++GmT5w5S/i4dtBQ== X-Received: by 10.36.79.132 with SMTP id c126mr5922694itb.45.1515445782952; Mon, 08 Jan 2018 13:09:42 -0800 (PST) Received: from mail-io0-f176.google.com (mail-io0-f176.google.com. [209.85.223.176]) by smtp.gmail.com with ESMTPSA id p68sm7192688itc.26.2018.01.08.13.09.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jan 2018 13:09:42 -0800 (PST) Received: by mail-io0-f176.google.com with SMTP id e20so16116976iof.12; Mon, 08 Jan 2018 13:09:42 -0800 (PST) X-Received: by 10.107.53.223 with SMTP id k92mr13296236ioo.38.1515445782501; Mon, 08 Jan 2018 13:09:42 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.2.15.193 with HTTP; Mon, 8 Jan 2018 13:09:42 -0800 (PST) In-Reply-To: <89964e3f-a982-f0e5-a7ff-9c13a5ebe61c@FreeBSD.org> References: <201801081609.w08G9941022351@pdx.rh.CN85.dnsmgr.net> <89964e3f-a982-f0e5-a7ff-9c13a5ebe61c@FreeBSD.org> From: Conrad Meyer Date: Mon, 8 Jan 2018 13:09:42 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r327699 - head/sys/sys To: Pedro Giffuni Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Jan 2018 21:09:50 -0000 On Mon, Jan 8, 2018 at 12:54 PM, Pedro Giffuni wrote: > Yeah, I understand where that comes from and I will take it into account = for > future commits, but I think it should be *documented* and not assume that > everybody thinks that is the way version control is supposed to be used. If you want to document it somewhere, I don't think anyone will stop you. In general, we do have a bunch of unwritten guidelines that are either inferred from reading SVN log / source or explicitly requested via review (pre- or post-commit). I don't think it would hurt to document. I don't know if this specific topic is really a FreeBSD guideline or not, but it's a good practice when using any version control system. (You could do the same thing with 'git revert' =E2=80=94 make additions on = top of the revert commit =E2=80=94 and it would be equally a bad practice with that tool.) The only downsides I see are: 0. No one is interested in spending time writing this down and dealing with the inevitable bikeshedding, 1. Consensus may shift over time, and 2. People don't want to spend a ton of time reading rules Best, Conrad