From owner-freebsd-net@FreeBSD.ORG Fri Sep 8 01:08:46 2006 Return-Path: X-Original-To: freebsd-net@freebsd.org Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C9C4316A4E5 for ; Fri, 8 Sep 2006 01:08:46 +0000 (UTC) (envelope-from thompsa@freebsd.org) Received: from grunt3.ihug.co.nz (grunt3.ihug.co.nz [203.109.254.43]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0FAAD43D55 for ; Fri, 8 Sep 2006 01:08:42 +0000 (GMT) (envelope-from thompsa@freebsd.org) Received: from 203-109-251-39.static.bliink.ihug.co.nz (heff.fud.org.nz) [203.109.251.39] by grunt3.ihug.co.nz with esmtp (Exim 3.35 #1 (Debian)) id 1GLUrE-0001Bt-00; Fri, 08 Sep 2006 13:08:36 +1200 Received: by heff.fud.org.nz (Postfix, from userid 1001) id 3C92D1CC23; Fri, 8 Sep 2006 13:08:35 +1200 (NZST) Date: Fri, 8 Sep 2006 13:08:35 +1200 From: Andrew Thompson To: Andre Oppermann Message-ID: <20060908010835.GA6334@heff.fud.org.nz> References: <450035AD.3040600@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <450035AD.3040600@freebsd.org> User-Agent: Mutt/1.5.11 Cc: freebsd-net@freebsd.org, yar@comp.chem.msu.su, freebsd-arch@freebsd.org Subject: Re: Moving ethernet VLAN tags into the mbuf packet header (from mtags) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Sep 2006 01:08:46 -0000 On Thu, Sep 07, 2006 at 05:07:25PM +0200, Andre Oppermann wrote: > With the recent addition of a 16bit field for TSO into the mbuf packet > header we've got 16bits left over. I've reserved these bits for the > ethernet VLAN tagging of packet to do away with the allocated mbuf mtag. > > The change is rather mechanical. Patch available here: > > http://people.freebsd.org/~andre/vlan_pkthdr-20060907.diff > RCS file: /home/ncvs/src/sys/netgraph/ng_vlan.c,v retrieving revision 1.3 diff -u -p -r1.3 ng_vlan.c --- netgraph/ng_vlan.c 20 Apr 2005 14:19:20 -0000 1.3 +++ netgraph/ng_vlan.c 7 Sep 2006 15:03:58 -0000 <...> - vlan = EVL_VLANOFTAG(VLAN_TAG_VALUE(mtag)); + vlan = m->m_pkthdr.ether_vlan; (void)&evl; /* XXX silence GCC */ I think this is a typeo, EVL_VLANOFTAG is still needed. I like the change and it helps out a few related projects that people are working on. Andrew