From nobody Mon Jul 7 15:24:23 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bbShV27Jcz61xrR for ; Mon, 07 Jul 2025 15:24:26 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bbShT6Ztqz472P for ; Mon, 07 Jul 2025 15:24:25 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Authentication-Results: mx1.freebsd.org; none Received: by mail-io1-xd2b.google.com with SMTP id ca18e2360f4ac-875ce3c8e24so117426039f.1 for ; Mon, 07 Jul 2025 08:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; t=1751901865; x=1752506665; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7Oj4zufyOU55CCDmncF6ZMzitjRYF3wUKgc1KUZ/rzw=; b=YYZv5Rqym1SndPjfD1w6TDGrMkROoNgXM27xwpgQ2SrLFnu3ejuiYPBpnXLJsqfEn2 uoRWTyoIR5tbUBcBVmVTviniYArchZX+muubSlLDUoU0m4qG/vc2zKvr93i8EXl+T0RU jp0arB6CcRWGfR41EzQ6jIKsuUq/qPRNR93nBrIDyVdYOIkvEPD0avbwTP8HePhZVSyK ++FTiVNMDXNWZMSc/6rIq/+brmTeRZvqqqAbZhYZFcZpS58n86gOnrbsz3k7eBYvbWpp QRVPNFdwriqyTwHLGn4ulSLW0J3Ir1zHvJsXpLE5HXRrUzP1kcw/M9TtWNLO9aJUGMAc dlcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751901865; x=1752506665; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7Oj4zufyOU55CCDmncF6ZMzitjRYF3wUKgc1KUZ/rzw=; b=BQM/DYMu/D7sdrDyT93ZDLMjoJXutjQjoNfWXRtjI40pX5lIXuwbmi9xf3OMbuIVOV DR4zGCzNcN5QpFLAGHpuWsdYomq7S4sQ/463csEYkshiHt+RDzU7voDvCICNolI58TMy JDzwhWmAIzrWG5UpsJAQGcKD0SxR/ndRncRzfD2Bt6N7WZ8gMrCcFCtoi+SkIcjdE1qt ZplSHPaHsDkUU46yBGjSne/DOihJkay0dFSg+8jM+2FDjAyioHRvJXIQbFXqazcCAcL1 Zirrq2GMGOF3cAOAcqpbv4LPtYk1so0jSh+Ck74sEprGlUgrJHoJ9UvURAsXLZLYeXMe jT3w== X-Forwarded-Encrypted: i=1; AJvYcCWQYMssBLSMIV5GHRlvJXL4rhKqsn8k7EKr+Zcz6/otqSOhghB3Xxn5KMywOysDvDjUe0fuek5T5NdiX6I1YBbtJYnc@freebsd.org X-Gm-Message-State: AOJu0YyZcDxKyTBm0L7fOggnawa7iLBZyyQqX+z4rfbgfvhgOngtce/M hEChdv2oL+IvdFQ/rv57tq6gBi1Z6wydo/35m9hi5WhQzjGxYiZeUzAPj1hpIVCLPTQ= X-Gm-Gg: ASbGncsZjS6h+i2p5F2RlhhY7FiFQVFojY2AUOCtRv3C7LUScRyKkRccTpS821QPiVs 5KaqJbQ7+XkHOLE/ll2S5AFNocGpb4tW/foY3xrI0qP54yfnZ/11WfktvTRu6tjDpnuqeh7+1Ry 9qP5DuiIobqComQl4CdVZRbCKziOZxQXS1wRHwKAUDRZGTsa+X7OfvRRW6+h92fIUsYCwbu0Bv+ h/gMkP/YFXPomweyYAUZhvrmu7Sndu5BGBcEFOqRcLToOFQJl1+NQkulsKttUxLWcSewhfhIZZ9 H7d4In0q1dymmcGiQieHmiIjYRvvvja1mA0jfAaSqvV86pTiJDwu948= X-Google-Smtp-Source: AGHT+IG9fOArTxOHDazxQj7+1r9f03uMaABuN/4AkS/Ryd4Y/uQqTG+hW9Ts7VzaiNqRUdbpYifAiw== X-Received: by 2002:a05:6602:2b93:b0:876:a951:b272 with SMTP id ca18e2360f4ac-8794a3b2afbmr3406239f.3.1751901864652; Mon, 07 Jul 2025 08:24:24 -0700 (PDT) Received: from mutt-hbsd ([2001:470:4001:1::95]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-876e0858ac8sm219549839f.32.2025.07.07.08.24.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jul 2025 08:24:24 -0700 (PDT) Date: Mon, 7 Jul 2025 15:24:23 +0000 From: Shawn Webb To: Mark Johnston Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 71a0af25a535 - main - libopenbsd: Add recallocarray() Message-ID: X-Operating-System: FreeBSD mutt-hbsd 14.3-STABLE-HBSD FreeBSD 14.3-STABLE-HBSD HARDENEDBSD-14-STABLE amd64 X-PGP-Key: https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/blob/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc References: <202507062318.566NIhSM031303@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wpjsuxfexknztctl" Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4bbShT6Ztqz472P X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] --wpjsuxfexknztctl Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: git: 71a0af25a535 - main - libopenbsd: Add recallocarray() MIME-Version: 1.0 On Mon, Jul 07, 2025 at 11:20:27AM -0400, Mark Johnston wrote: > On Mon, Jul 07, 2025 at 03:13:29PM +0000, Shawn Webb wrote: > > Hey Mark, > >=20 > > I've noted a couple things. > >=20 > > On Sun, Jul 06, 2025 at 11:18:43PM +0000, Mark Johnston wrote: > > > The branch main has been updated by markj: > > >=20 > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D71a0af25a5353f929521cb= 04c73a7266ac5b7b61 > > >=20 > > > commit 71a0af25a5353f929521cb04c73a7266ac5b7b61 > > > Author: Ricardo Branco > > > AuthorDate: 2025-06-16 21:41:48 +0000 > > > Commit: Mark Johnston > > > CommitDate: 2025-07-06 23:09:00 +0000 > > >=20 > > > libopenbsd: Add recallocarray() > > > =20 > > > Reviewed by: kib > > > MFC after: 1 month > > > Pull Request: https://github.com/freebsd/freebsd-src/pull/1698 > >=20 > > That appears to be the PR for POSIX O_CLOFORK. >=20 > Correct. >=20 > > > --- > > > lib/libopenbsd/Makefile | 3 +- > > > lib/libopenbsd/recallocarray.c | 82 ++++++++++++++++++++++++++++++++= ++++++++++ > > > 2 files changed, 84 insertions(+), 1 deletion(-) > >=20 > > FreeBSD commit 450dfafb1519ae7bb0615368ba45813bcabb9b35 back in 2015 > > imported a different version of OpenBSD's reallocarray into libc. > > Would it make sense to have only one reallocarray implementation? Or > > what's the justification for having two implementations of the same > > function? What might happen if someone links against both libc and > > libopenbsd? >=20 > Note, this is recallocarray(), not reallocarray(). libc has the latter, > this commit added an implementation of the former to libopenbsd. What a difference one letter can make, haha. I certainly missed the extra "c". Sorry for the noise and thanks for the clarification. --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Signal Username: shawn_webb.74 Tor-ified Signal: +1 303-901-1600 / shawn_webb_opsec.50 https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A= 4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc --wpjsuxfexknztctl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmhr5pcACgkQ/y5nonf4 4fqJfA/8C0ihGJmFHiLheWZdWZPWlOMcCeMTL7qIs44GYpyN0i3w9Ie6d/sGSnbS N7FNFtx9LzKAo+Q6pyfgU852LvwCLHdTqYgY/McIfkPT7v2OJdPl7v0SS0fG6u5j TUVsH3Sjiaao/ESdTkoehNPRZbOYz0t81SIpb5RBDKhr2fLnTpWdZsGJQp3tXzY4 7fZXzR6e3hPQTgnQYidPkmEu2Q8JrwlZsKQPOO/z2c9tZwLFhwa3yelduffj3bm4 AldyT0tNFr0HE1PlhdYawkDYrZQ8z0XS4pxM/Z3U1HjaCk5Ok0ti0GhFWBau+Kue GHpRJTkQObVJ7Mrq+S52TU9p0qmKSEnBZw4vLhYBGGaNsBW7SelT5PqdvL3bg0Di NBb+lsUkCGmLSxGJmpFow4bAhQ9pzBxhiIQ2s2vZEmW0tsRvOgn52Rtn6P287Qo+ LzSo49+jWE40EUt4bzPUo+n8+NCHXaCeIJTcEkeorrcb5ypU9YkpFtcnJWL2iu74 YJTTDnmqKK2jU78JVmkP1ZRP0aA+/yHpcJXpRzjIbblCMASdzhbCF8Oq1Jf0mMVY HgJ298WOBf2lJdXtS5snQk3TIUhaVGioDJH75w0p8lQ0lPb8HeK+e/1AXROTLwK8 UK15Iiirhm1tReHCN9KWFL4Nixj4Cvsr3blaigJXtD7G+tnQs1o= =8Mz7 -----END PGP SIGNATURE----- --wpjsuxfexknztctl--