From owner-cvs-ports@FreeBSD.ORG Mon Jan 19 10:49:33 2004 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C2F0F16A4CE; Mon, 19 Jan 2004 10:49:33 -0800 (PST) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 693DF43D2F; Mon, 19 Jan 2004 10:49:31 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.10/8.12.9) with ESMTP id i0JInUip006567; Mon, 19 Jan 2004 10:49:31 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.10/8.12.10/Submit) id i0JInURd006566; Mon, 19 Jan 2004 10:49:30 -0800 (PST) (envelope-from obrien) Date: Mon, 19 Jan 2004 10:49:30 -0800 From: "David O'Brien" To: Pav Lucistnik Message-ID: <20040119184930.GC6433@dragon.nuxi.com> References: <200401191544.i0JFib85052132@repoman.freebsd.org> <20040119163258.GB4722@dragon.nuxi.com> <359167705.1074533881@andromede.reaumur.absolight.net> <1074530713.53674.9.camel@pav.hide.vol.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1074530713.53674.9.camel@pav.hide.vol.cz> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.2-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: Mathieu Arnold cc: cvs-ports@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/mail/p5-Mail-SpamAssassin Makefile distinfo pkg-plist X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jan 2004 18:49:33 -0000 On Mon, Jan 19, 2004 at 05:45:14PM +0100, Pav Lucistnik wrote: > V po, 19. 01. 2004 v 17:38, Mathieu Arnold p??e: > > > |> mat 2004/01/19 07:44:37 PST > > |> > > |> FreeBSD ports repository > > |> > > |> Modified files: > > |> mail/p5-Mail-SpamAssassin Makefile distinfo pkg-plist > > |> Log: > > |> Update to 2.62 > > |> Have the least thing possible between bsd.port.pre.mk and post.mk > > | > > | Please back this out. It is hard to read and find the dependencies. The > > | Porter's handbook clearly documents where w/in a port's Makefile > > | {BUILD,RUN}_DEPENDS belong in the Makefile. > > > > Do you really mean that every perl port that does this should be changed ? > > it's the first time someone tells me so. > > I don't see any problem with having conditional dependencies specified > in the very bottom of a Makefile ... even, I like it more this way. It is against the Porter's Handbook for one, against 10 years of how a port's Makefile is organized, and they are hard to find -- people read Makefile's also, not just make(1). http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile.html Chapter 5 Configuring the Makefile ... Also, there is a sample Makefile in this handbook, so take a look and please follow the ordering of variables and sections in that template to make your port easier for others to read. http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-samplem.html Chapter 17 A Sample Makefile ... It is recommended that you follow this format (ordering of variables, empty lines between sections, etc.). This format is designed so that the most important information is easy to locate.