From owner-freebsd-hackers Wed Nov 15 00:15:28 1995 Return-Path: owner-hackers Received: (from root@localhost) by freefall.freebsd.org (8.6.12/8.6.6) id AAA05305 for hackers-outgoing; Wed, 15 Nov 1995 00:15:28 -0800 Received: from Root.COM (implode.Root.COM [198.145.90.17]) by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id AAA05294 for ; Wed, 15 Nov 1995 00:15:25 -0800 Received: from corbin.Root.COM (corbin [198.145.90.50]) by Root.COM (8.6.12/8.6.5) with ESMTP id AAA01802; Wed, 15 Nov 1995 00:15:24 -0800 Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.12/8.6.5) with SMTP id AAA00161; Wed, 15 Nov 1995 00:15:22 -0800 Message-Id: <199511150815.AAA00161@corbin.Root.COM> To: Bruce Evans cc: peter@haywire.dialix.com, freebsd-hackers@freebsd.org Subject: Re: Can't NFS mount with latest -current In-reply-to: Your message of "Wed, 15 Nov 95 19:06:56 +1100." <199511150806.TAA25412@godzilla.zeta.org.au> From: David Greenman Reply-To: davidg@Root.COM Date: Wed, 15 Nov 1995 00:15:21 -0800 Sender: owner-hackers@freebsd.org Precedence: bulk >>>Anyway, Poul-Henning has created two sysctl types.. one is a >>>null-terminated "C-style" string, and the other is an "opaque" chunk >>>of byte counted memory. IMHO, the string version should always return >>>the correct amount of characters that the string actually uses. If >>>the whole block is to be returned, that's what the opaque type is for. > >> Yes, the "size" argument should be used to limit the copy, not prevent it >>from happening. We should be using copyoutstr() for this. > >We shouldn't be using copyoutstr() for this. ... >copyoutstr() is the most complicated routine in support.s, but is >currently unused. Are you saying that you would like to officially remove support for copyoutstr() in favor of strlen/copyout? I can agree with that. BTW, we should remove the #if 0'd crap in cpufunc.h: #if 0 /* * These functions in support.s are declared elsewhere. */ ... -DG