From owner-freebsd-audit Tue Oct 8 18: 1:24 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2667B37B401; Tue, 8 Oct 2002 18:01:23 -0700 (PDT) Received: from kayak.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226]) by mx1.FreeBSD.org (Postfix) with ESMTP id D038F43E65; Tue, 8 Oct 2002 18:01:21 -0700 (PDT) (envelope-from marcel@xcllnt.net) Received: from dhcp01.pn.xcllnt.net (dhcp01.pn.xcllnt.net [192.168.4.201]) by kayak.xcllnt.net (8.11.6/8.11.4) with ESMTP id g9911Lt95374; Tue, 8 Oct 2002 18:01:21 -0700 (PDT) (envelope-from marcel@kayak.pn.xcllnt.net) Received: from dhcp01.pn.xcllnt.net (localhost [127.0.0.1]) by dhcp01.pn.xcllnt.net (8.12.6/8.12.6) with ESMTP id g9913FIS000676; Tue, 8 Oct 2002 18:03:15 -0700 (PDT) (envelope-from marcel@dhcp01.pn.xcllnt.net) Received: (from marcel@localhost) by dhcp01.pn.xcllnt.net (8.12.6/8.12.6/Submit) id g99139ic000675; Tue, 8 Oct 2002 18:03:09 -0700 (PDT) Date: Tue, 8 Oct 2002 18:03:09 -0700 From: Marcel Moolenaar To: Maxim Sobolev Cc: Alfred Perlstein , emulation@FreeBSD.org, audit@FreeBSD.org Subject: Re: Linuxlator patches for review [was: Who currently maintains Linuxlator?] Message-ID: <20021009010309.GA607@dhcp01.pn.xcllnt.net> References: <20021006110243.GA70993@vega.vega.com> <20021006183650.GY95327@elvis.mu.org> <3DA2BE32.BDEC28B5@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3DA2BE32.BDEC28B5@FreeBSD.org> User-Agent: Mutt/1.5.1i Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Oct 08, 2002 at 02:14:58PM +0300, Maxim Sobolev wrote: > See attached. As it was suggested, I'm also CC'ing marcel, > freebsd-audit and freebsd-emulation. I'd like to hear any suggestion > or comments. Please note that changes were not tested on alpha, > because I don't have any axp hardware. I can test on Alpha, provided the patch is against -current. Do you have some test cases? > /* > + * VFAT > + */ > +#define LINUX_VFAT_READDIR_BOTH 0x7201 > + > +#define LINUX_IOCTL_VFAT_MIN LINUX_VFAT_READDIR_BOTH > +#define LINUX_IOCTL_VFAT_MAX LINUX_VFAT_READDIR_BOTH > + > +/* Silly question: The VFAT ioctl is not implemented. Is there a bigger picture? Also: is it worth having a VFAT handler if there's only 1 ioctl (again, there might be a bigger picture)? > case LINUX_IPC_INFO: > case LINUX_SEM_INFO: > - error = copyin((caddr_t)args->arg.buf, &linux_seminfo, > - sizeof(linux_seminfo) ); > - if (error) > - return error; > bcopy(&seminfo, &linux_seminfo, sizeof(linux_seminfo) ); > /* XXX BSD equivalent? > #define used_semids 10 Should the copyin be replaced with something or was the copyin bogus? Other than that: looks good. I merely skimmed over it, so I may have missed a detail.... -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message