From owner-svn-src-all@FreeBSD.ORG Tue Feb 28 07:13:12 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A1024106566B; Tue, 28 Feb 2012 07:13:12 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.59.238]) by mx1.freebsd.org (Postfix) with ESMTP id 578268FC08; Tue, 28 Feb 2012 07:13:11 +0000 (UTC) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id EB4A67300A; Tue, 28 Feb 2012 08:31:22 +0100 (CET) Date: Tue, 28 Feb 2012 08:31:22 +0100 From: Luigi Rizzo To: Ben Kaduk Message-ID: <20120228073122.GC57270@onelab2.iet.unipi.it> References: <201202271905.q1RJ52Se032771@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Cc: svn-src-head@freebsd.org, Luigi Rizzo , src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r232238 - in head: share/man/man4 sys/dev/e1000 sys/dev/ixgbe sys/dev/netmap sys/dev/re sys/net tools/tools/netmap X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Feb 2012 07:13:12 -0000 On Mon, Feb 27, 2012 at 07:05:45PM -0500, Ben Kaduk wrote: ... > > ?1. add support for devices with different number of rx and tx queues; > > > > ?2. add better support for zero-copy operation, adding an extra field > > ? ? to the netmap ring to indicate how many buffers we have already processed > > ? ? but not yet released (with help from Eddie Kohler); > > > > ?3. The two changes above unfortunately require an API change, so while > > ? ? at it add a version field and some spares to the ioctl() argument > > ? ? to help detect mismatches. > > Is it worth bumping __FreeBSD_version? I don't think it is necessary. There is basically no code that uses the netmap API except for the examples in tools/tools/netmap, and i now have a NETMAP_API macro that defines the version without the need for using __FreeBSD_version cheers luigi