From owner-freebsd-ports@FreeBSD.ORG  Thu Nov  1 02:37:39 2007
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F423E16A419
	for <ports@freebsd.org>; Thu,  1 Nov 2007 02:37:38 +0000 (UTC)
	(envelope-from wblock@wonkity.com)
Received: from wonkity.com (wonkity.com [67.158.26.137])
	by mx1.freebsd.org (Postfix) with ESMTP id AC8AC13C494
	for <ports@freebsd.org>; Thu,  1 Nov 2007 02:37:38 +0000 (UTC)
	(envelope-from wblock@wonkity.com)
Received: from speedy.wonkity.com (speedy.wonkity.com [10.0.0.7])
	by wonkity.com (8.14.1/8.14.1) with ESMTP id lA12b5SU071549
	for <ports@freebsd.org>; Wed, 31 Oct 2007 20:37:05 -0600 (MDT)
	(envelope-from wblock@wonkity.com)
Received: from speedy.wonkity.com (localhost [127.0.0.1])
	by speedy.wonkity.com (8.14.1/8.14.1) with ESMTP id lA12b5VE016052
	for <ports@freebsd.org>; Wed, 31 Oct 2007 20:37:05 -0600 (MDT)
	(envelope-from wblock@wonkity.com)
Received: from localhost (wblock@localhost)
	by speedy.wonkity.com (8.14.1/8.14.1/Submit) with ESMTP id
	lA12b5W9016049
	for <ports@freebsd.org>; Wed, 31 Oct 2007 20:37:05 -0600 (MDT)
	(envelope-from wblock@wonkity.com)
X-Authentication-Warning: speedy.wonkity.com: wblock owned process doing -bs
Date: Wed, 31 Oct 2007 20:37:04 -0600 (MDT)
From: Warren Block <wblock@wonkity.com>
To: ports@freebsd.org
Message-ID: <20071031190814.C15171@speedy.wonkity.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0
	(wonkity.com [10.0.0.1]); Wed, 31 Oct 2007 20:37:05 -0600 (MDT)
Cc: 
Subject: bsd.sites.mk changes (was Re: Xfce goodies master sites)
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Nov 2007 02:37:39 -0000

The questions: is this the right thing to do and is it the right way to 
go about it?

If bsd.sites.mk is changed as shown below, all of the xfce "goodies" 
ports can use

   MASTER_SITES=   ${MASTER_SITE_XFCE_GOODIES}

That will unify all of the goodies ports and ease future changes like 
additional mirrors or moves.

There are currently 26 ports of xfce goodies (not counting the 
xfce-notification-daemon port, which I haven't submitted yet):

  #find /usr/ports -name Makefile -exec grep -l goodies.xfce.org {} \+

Proposed changes to bsd.sites.mk:

--- bsd.sites.mk.orig   2007-10-30 16:58:47.000000000 -0600
+++ bsd.sites.mk        2007-10-31 18:43:01.000000000 -0600
@@ -1359,6 +1359,11 @@
         http://www.p0llux.be/xfce/%SUBDIR%/src/
  .endif

+.if !defined(IGNORE_MASTER_SITE_XFCE_GOODIES)
+MASTER_SITE_XFCE_GOODIES+= \
+       http://goodies.xfce.org/releases/${PORTNAME}/
+.endif
+
  .if !defined(IGNORE_MASTER_SITE_XFREE)
  MASTER_SITE_XFREE+= \
         http://www.gtlib.cc.gatech.edu/pub/XFree86/%SUBDIR%/source/ \

-Warren Block * Rapid City, South Dakota USA