From owner-svn-src-all@freebsd.org Fri Oct 21 22:02:49 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B3EBBC1B8A8 for ; Fri, 21 Oct 2016 22:02:49 +0000 (UTC) (envelope-from 01000157e944783d-5458f67c-26df-45fc-b823-c9ffdcfeeaab-000000@amazonses.com) Received: from a8-237.smtp-out.amazonses.com (a8-237.smtp-out.amazonses.com [54.240.8.237]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7943DCED for ; Fri, 21 Oct 2016 22:02:48 +0000 (UTC) (envelope-from 01000157e944783d-5458f67c-26df-45fc-b823-c9ffdcfeeaab-000000@amazonses.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=vnqrkfnvu6csdl6mwgk5t6ix3nnepx57; d=tarsnap.com; t=1477087361; h=Subject:To:References:Cc:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=5/9p1hmMhe0/0W0k6n+PEg/Z4CfuCuzN2Ej5fCYDiWg=; b=IpIzPntEFYqNT7inm+Ozeb5tCO/XZPddRCai1hHLCddSuVURhqA3XS/UJM+W/tqV L1BtyoIJjxMEZHyVvueaODd50XSZ8zijF+Lp9v4z0Z3uOe91RQUvikbRbwdwJvkBo7T B6HQxrWu6+O0LSH2QfJ0HNYa5JswIJF+MLiCdTjQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=6gbrjpgwjskckoa6a5zn6fwqkn67xbtw; d=amazonses.com; t=1477087361; h=Subject:To:References:Cc:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:Feedback-ID; bh=5/9p1hmMhe0/0W0k6n+PEg/Z4CfuCuzN2Ej5fCYDiWg=; b=GE1Q1MTfaJ9aa8d/L21W91KAYpnr8/dxbzhK1TehRInx6pTw6j0uJfvYPZx/ELDL XrvBKweiYQkx9yTGN2J0XxoluUT4imuf8OYVFXiEShAugTZO2Y4/B6DmcJqHKv9Rpt+ dm1CswL0UapmbUceSalFyudcx31rJlq7VoJVVwPA= Subject: Re: cvs commit: src/sys/sys _types.h resource.h To: =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= References: <200411081805.iA8I5hVK038813@repoman.freebsd.org> <01000157e3ac7982-b19e61c1-1619-44b1-88b5-3080d85e8d6d-000000@email.amazonses.com> <86wph1o8ec.fsf@desk.des.no> Cc: src-committers@FreeBSD.org, "svn-src-all@freebsd.org" From: Colin Percival Message-ID: <01000157e944783d-5458f67c-26df-45fc-b823-c9ffdcfeeaab-000000@email.amazonses.com> Date: Fri, 21 Oct 2016 22:02:41 +0000 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <86wph1o8ec.fsf@desk.des.no> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SES-Outgoing: 2016.10.21-54.240.8.237 Feedback-ID: 1.us-east-1.Lv9FVjaNvvR5llaqfLoOVbo2VxOELl7cjN0AOyXnPlk=:AmazonSES X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2016 22:02:49 -0000 On 10/21/16 11:37, Dag-Erling Smørgrav wrote: > Colin Percival writes: >> Dag-Erling Smørgrav writes: >>> -typedef __int64_t __rlim_t; /* resource limit (XXX not unsigned) */ >>> +typedef __int64_t __rlim_t; /* resource limit - intentionally */ >>> + /* signed, because of legacy code */ >>> + /* that uses -1 for RLIM_INFINITY */ >> Is it time to drop compatibility for code which was "legacy" 12 years ago >> in order to conform to the POSIX stipulation that rlim_t should be unsigned? > > Well, all of that code is already broken because I defined RLIM_INFINITY > to 2^63-1 instead of 2^64-1. But we might as well align ourselves with > the legacy code (and with other OSes), as the consequences of changing > RLIM_INFINITY are mostly cosmetic [...] I wasn't talking about the value of RLIM_INFINITY, but rather about whether rlim_t should be signed or unsigned. Right now it is signed; but POSIX says it should be unsigned, and most other OSes follow POSIX's mandate here. -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid