Date: Mon, 16 Mar 2015 05:18:43 -0500 From: "Matthew D. Fuller" <fullermd@over-yonder.net> To: Pawel Jakub Dawidek <pjd@FreeBSD.org> Cc: freebsd-geom@freebsd.org Subject: Re: RFC: Pass TRIM through GELI Message-ID: <20150316101843.GE52331@over-yonder.net> In-Reply-To: <20150316101323.GD52331@over-yonder.net> References: <20150308000131.GP1742@over-yonder.net> <20150314151453.GJ24274@over-yonder.net> <501bca86.508d8e26@fabiankeil.de> <20150315145324.GA52331@over-yonder.net> <20150315182444.GB52331@over-yonder.net> <20150316010845.GA1515@garage.freebsd.pl> <20150316092126.GC52331@over-yonder.net> <20150316100030.GB1515@garage.freebsd.pl> <20150316101323.GD52331@over-yonder.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 16, 2015 at 05:13:23AM -0500 I heard the voice of Matthew D. Fuller, and lo! it spake thus: > > , so eli_metadata_decode() EINVAL's right up at the top before > filling anything into the passed md. As a result, in > g_eli_ctl_configure(), it gets (keeps) stack garbage in the var. As a side note, this seems to turn from "darn" to "panic" because in g_eli_read_metadata(), it doesn't check the return from eli_metadata_decode(), so it doesn't notice the EINVAL and happily reports back success without ever having touched the md :( -- Matthew Fuller (MF4839) | fullermd@over-yonder.net Systems/Network Administrator | http://www.over-yonder.net/~fullermd/ On the Internet, nobody can hear you scream.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150316101843.GE52331>