From owner-freebsd-ports-bugs@freebsd.org Fri Jun 19 20:01:22 2020 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A6245337B73 for ; Fri, 19 Jun 2020 20:01:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 49pV7641dgz3W0L for ; Fri, 19 Jun 2020 20:01:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 89F0733821D; Fri, 19 Jun 2020 20:01:22 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 89B36337B72 for ; Fri, 19 Jun 2020 20:01:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49pV7639S0z3W0K for ; Fri, 19 Jun 2020 20:01:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 6839920999 for ; Fri, 19 Jun 2020 20:01:22 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 05JK1Miw054727 for ; Fri, 19 Jun 2020 20:01:22 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 05JK1M5A054726 for ports-bugs@FreeBSD.org; Fri, 19 Jun 2020 20:01:22 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 247431] sysutils/bsdisks: coredumps on postponed registration processing due to wrong iteration Date: Fri, 19 Jun 2020 20:01:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: osidorkin@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: arrowd@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2020 20:01:22 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D247431 Bug ID: 247431 Summary: sysutils/bsdisks: coredumps on postponed registration processing due to wrong iteration Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: arrowd@FreeBSD.org Reporter: osidorkin@gmail.com Assignee: arrowd@FreeBSD.org Flags: maintainer-feedback?(arrowd@FreeBSD.org) Created attachment 215797 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D215797&action= =3Dedit Fix iteration over postponed registrations set When entry is removed whth QSet<>::erase() the iterator is invalidated so it should not be used anymore. Iterator returned by QSet<>::erase() call shoul= d be used instead and not incremented on the given loop iteration (https://doc.qt.io/qt-5/qset-iterator.html) The attached patch fixes looping (and my coredump). bsdisks log is the following: ..... "Registering /org/freedesktop/UDisks2/block_devices/nvd0p1" Pop "nvd0p1" from m_postponedRegistrations =D0=9E=D1=88=D0=B8=D0=B1=D0=BA=D0=B0 =D0=B0=D0=B4=D1=80=D0=B5=D1=81=D0=B0= =D1=86=D0=B8=D0=B8 =D0=BD=D0=B0 =D1=88=D0=B8=D0=BD=D0=B5(core dumped) --=20 You are receiving this mail because: You are the assignee for the bug.=