From owner-freebsd-current  Sun Feb 16 03:52:57 1997
Return-Path: <owner-current>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id DAA28241
          for current-outgoing; Sun, 16 Feb 1997 03:52:57 -0800 (PST)
Received: from time.cdrom.com (time.cdrom.com [204.216.27.226])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id DAA28223;
          Sun, 16 Feb 1997 03:52:38 -0800 (PST)
Received: (from jkh@localhost) by time.cdrom.com (8.8.5/8.6.9) id DAA14051; Sun, 16 Feb 1997 03:52:35 -0800 (PST)
Date: Sun, 16 Feb 1997 03:52:35 -0800 (PST)
From: "Jordan K. Hubbard" <jkh@time.cdrom.com>
Message-Id: <199702161152.DAA14051@time.cdrom.com>
To: dyson@freebsd.org
Subject: dump/traverse.c:118 build failure in -current
Cc: bde@freebsd.org, current@freebsd.org
Sender: owner-current@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

/* Auxiliary macro to pick up files changed since previous dump. */
#ifdef FS_44INODEFMT
#define CHANGEDSINCE(dp, t) \
        ((dp)->di_mtime.tv_sec >= (t) || (dp)->di_ctime.tv_sec >= (t))
#else
#define CHANGEDSINCE(dp, t) \
        ((dp)->di_mtime >= (t) || (dp)->di_ctime >= (t))
#endif

FS_44INODEFMT is defined as 2 /usr/include/ufs/ffs/fs.h and seems
to be correct, but struct dinode now contains an int32_t for di_mtime,
not a struct timespec as in former times.

So the question simply is:  Is the dinode structure wrong, with
FreeBSD changes to be brought back from revision 1.4 of dinode.h,
or does traverse.c simple need to collapse the above to:

#define CHANGEDSINCE(dp, t) \
        ((dp)->di_mtime >= (t) || (dp)->di_ctime >= (t))

And be done with it.  Where's the book on this stuff? :-)

					Jordan