From owner-freebsd-arch@FreeBSD.ORG Fri Mar 14 17:14:15 2014 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1D428CEB for ; Fri, 14 Mar 2014 17:14:15 +0000 (UTC) Received: from mail-ve0-x231.google.com (mail-ve0-x231.google.com [IPv6:2607:f8b0:400c:c01::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id C80B6669 for ; Fri, 14 Mar 2014 17:14:14 +0000 (UTC) Received: by mail-ve0-f177.google.com with SMTP id sa20so2966502veb.36 for ; Fri, 14 Mar 2014 10:14:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wemm.org; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=Q7cNBDXOXMcnanIQl7owX2i38cU5FJlRSLpGqrjQ3BI=; b=CGLsjHz2WP3uebNPG6UHZNUX2nxwIkWFY9DaGdijMk/ALoW2JdFnzccdL2rkDwlWRo VCtsOzCWzGBo0qM1RqPN05ttq8kEcKZkiekIyzv+rfGomQu5rzrC17nyVZleYTTiTmDj GuvjV1UndY2+JvQl20PLyUzzfgQzSczNIMASE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Q7cNBDXOXMcnanIQl7owX2i38cU5FJlRSLpGqrjQ3BI=; b=adYdTn4IA4/uj1ChWmUlPqmVCRYZYxvst5zWq49k6e/JK3cNrhxu01E/M3M17clQB5 8UfTQa18qjX6gROMvhNfVQq6hXX+mTOR4l5A8Iy0iQ1ovHyfD8meexpL0MQCDinEUXdM svHr3P8UYaJR0BUxXSaI/jIIdbTnmChw4S4lM7P04ndssh1/2wcLq6sP+UIHtz4WvV/N ZgCd+NsydT38EFhlyMpDN+lI/1u68H4gvr1ac0zCYVzHv0EYM2Ktcia1nxyMYV+pb07U F2VTConiUGuAajNrqmbWYAjbCEPCvzf56pHCDI/C/h+Mh+1KoTlnvv+1+xl64gN2Xod+ lsJQ== X-Gm-Message-State: ALoCoQkO9GCJW8hbjqbohq8eq7uUnLiG1oODjlia0O/kSVwi1zafwE++/QjzxdCgNzVKhsNZFibX MIME-Version: 1.0 X-Received: by 10.220.99.72 with SMTP id t8mr7299464vcn.10.1394817253854; Fri, 14 Mar 2014 10:14:13 -0700 (PDT) Received: by 10.220.30.69 with HTTP; Fri, 14 Mar 2014 10:14:13 -0700 (PDT) In-Reply-To: References: <1627768f8d03e34c68dbe72038033a2d@shatow.net> Date: Fri, 14 Mar 2014 10:14:13 -0700 Message-ID: Subject: Re: Renaming cnt to vm_cnt From: Peter Wemm To: Bryan Drewery Content-Type: text/plain; charset=ISO-8859-1 Cc: FreeBSD Arch X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Mar 2014 17:14:15 -0000 On Fri, Mar 14, 2014 at 7:24 AM, Bryan Drewery wrote: > On 2014-03-14 09:20, Bryan Drewery wrote: >> >> Hi, >> >> http://people.freebsd.org/~bdrewery/patches/cnt_vm_cnt.diff >> >> I would like to rename the vmmeter.h global cnt to vm_cnt. >> It is quite a generic variable to be polluting the global >> namespace. The variable is only defined in _KERNEL, so >> there is no userland/KBI risk. > > > I take that back. I will do an exp-run at least to ensure no ports with > modules need fixing. It's more than just modules - things like lsof, net-snmp etc are likely candidates to check too. Anything that uses libkvm or /dev/kmem. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI6FJV Yes, I know, gmail sucks now. If you see this then I forgot. Habits are hard to break.