Date: Sun, 18 Dec 2011 03:16:40 +0100 From: Joerg Sonnenberger <joerg@britannica.bec.de> To: svn-src-all@freebsd.org Subject: Re: svn commit: r228650 - head/usr.bin/netstat Message-ID: <20111218021640.GA2436@britannica.bec.de> In-Reply-To: <4C98B8D8-99F6-4996-A0FB-C128D9384180@lists.zabbadoz.net> References: <201112171721.pBHHLloU069166@svn.freebsd.org> <4C98B8D8-99F6-4996-A0FB-C128D9384180@lists.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Dec 17, 2011 at 09:53:56PM +0000, Bjoern A. Zeeb wrote: > > On 17. Dec 2011, at 17:21 , Dimitry Andric wrote: > > > Author: dim > > Date: Sat Dec 17 17:21:47 2011 > > New Revision: 228650 > > URL: http://svn.freebsd.org/changeset/base/228650 > > > > Log: > > In usr.bin/netstat/atalk.c, work around a clang false positive with > > printf format warnings and conditional operators. > > > > This does not sound like a good idea. Make clang work. Strictly speaking, clang is correct here. While the 'h' modifier is effectively a nop due to integer promotion rules, the intention is clearly "I am going to use a unsigned short here". Of course, the bug in the change is that it is using short... Joerg
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111218021640.GA2436>