From owner-cvs-all Fri Feb 21 17: 0:22 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7AAB637B401 for ; Fri, 21 Feb 2003 17:00:20 -0800 (PST) Received: from ephemeral.chemikals.org (cae57-161-024.sc.rr.com [66.57.161.24]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7DCE643FE1 for ; Fri, 21 Feb 2003 17:00:19 -0800 (PST) (envelope-from morganw@chemikals.org) Received: from volatile.chemikals.org (root@adsl-18-176-81.gsp.bellsouth.net [68.18.176.81]) by ephemeral.chemikals.org (8.12.6/8.12.6) with ESMTP id h1M10AQt085522 for ; Fri, 21 Feb 2003 20:00:18 -0500 (EST) (envelope-from morganw@chemikals.org) Received: from localhost (morganw@localhost [127.0.0.1]) by volatile.chemikals.org (8.12.6/8.12.6) with ESMTP id h1M102sK069404 for ; Fri, 21 Feb 2003 20:00:04 -0500 (EST) (envelope-from morganw@chemikals.org) Date: Fri, 21 Feb 2003 20:00:02 -0500 (EST) From: Wesley Morgan To: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/ufs/ffs ffs_alloc.c ffs_extern.h ffs_snapshot.c In-Reply-To: <200302220029.h1M0Tpvi045454@repoman.freebsd.org> Message-ID: <20030221195807.K68622@volatile.chemikals.org> References: <200302220029.h1M0Tpvi045454@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, 21 Feb 2003, Kirk McKusick wrote: > mckusick 2003/02/21 16:29:51 PST > > Modified files: > sys/ufs/ffs ffs_alloc.c ffs_extern.h ffs_snapshot.c > Log: > This patch fixes a bug on an active filesystem on which a snapshot > is being taken from panicing with either "freeing free block" or > "freeing free inode". The problem arises when the snapshot code > is scanning the filesystem looking for inodes with a reference > count of zero (e.g., unlinked but still open) so that it can > expunge them from its view. If it encounters a reclaimed vnode > and has to restart its scan, then it will panic if it encounters > and tries to free an inode that it has already processed. The fix > is to check each candidate inode to see if it has already been > processed before trying to delete it from the snapshot image. Kirk always has the most interesting (and informative) commit messages. Sometimes its a little excuting just to see him making a commit. Just a thought :> ... Now back to your regularly scheduled programming! -- Hi! I'm a .signature virus! Copy me into your ~/.signature to help me spread! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message