From owner-svn-src-all@freebsd.org  Wed Jan  4 08:25:32 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id AE1EFC9EFD7;
 Wed,  4 Jan 2017 08:25:32 +0000 (UTC)
 (envelope-from ngie@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7DAD41C31;
 Wed,  4 Jan 2017 08:25:32 +0000 (UTC)
 (envelope-from ngie@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v048PVWB078612;
 Wed, 4 Jan 2017 08:25:31 GMT (envelope-from ngie@FreeBSD.org)
Received: (from ngie@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id v048PVPg078611;
 Wed, 4 Jan 2017 08:25:31 GMT (envelope-from ngie@FreeBSD.org)
Message-Id: <201701040825.v048PVPg078611@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: ngie set sender to
 ngie@FreeBSD.org using -f
From: Ngie Cooper <ngie@FreeBSD.org>
Date: Wed, 4 Jan 2017 08:25:31 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r311268 - head/contrib/netbsd-tests/lib/libc/sys
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Jan 2017 08:25:32 -0000

Author: ngie
Date: Wed Jan  4 08:25:31 2017
New Revision: 311268
URL: https://svnweb.freebsd.org/changeset/base/311268

Log:
  Clarify lifetime of child(..) function
  
  Ensure child exits when complete as it's always run in a forked
  process.
  
  Add a missing break statement in :pselect_sigmask when calling
  child(..) for clarity and to avoid weird domino effects if the
  child process somehow does something it's not supposed to do
  with the logfiles, file descriptors, etc
  
  MFC after:	1 week
  Reported by:	Coverity
  CID:		1223369, 1223370, 1300301

Modified:
  head/contrib/netbsd-tests/lib/libc/sys/t_select.c

Modified: head/contrib/netbsd-tests/lib/libc/sys/t_select.c
==============================================================================
--- head/contrib/netbsd-tests/lib/libc/sys/t_select.c	Wed Jan  4 08:12:31 2017	(r311267)
+++ head/contrib/netbsd-tests/lib/libc/sys/t_select.c	Wed Jan  4 08:25:31 2017	(r311268)
@@ -135,6 +135,9 @@ child(const struct timespec *ts)
 		    "after timeout %s != %s",
 		    prmask(&nset, nbuf, sizeof(nbuf)),
 		    prmask(&oset, obuf, sizeof(obuf)));
+#ifdef	__FreeBSD__
+	_exit(0);
+#endif
 }
 
 ATF_TC(pselect_sigmask);
@@ -154,6 +157,9 @@ ATF_TC_BODY(pselect_sigmask, tc)
 	switch (pid = fork()) {
 	case 0:
 		child(NULL);
+#ifdef	__FreeBSD__
+		break;
+#endif
 	case -1:
 		err(1, "fork");
 	default: