From nobody Sun Sep 28 15:00:31 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cZSDb6wrnz68q16; Sun, 28 Sep 2025 15:00:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cZSDb6RpPz3qSs; Sun, 28 Sep 2025 15:00:31 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759071631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DQwzQTJoaNhkGKnhJATWzY0wAk4iagAFxt1crgjRqvI=; b=qJwug8CWEhPACnCymkk0pIwHyhCrczNdGQHNQJN9T1yK0u5Tw/gNznHHX5ykLFJVAzMDvv hvVPR7Q2nycat4FeeQq3A43e+vbwao5WZhXK+FB+6mznt8IaxiyoZIL0su0tf9VmYgUna4 vlFEsVj7eTmxvhljzW+j+X7nhxtUzvGVliXIxsR18qyGRi1IMYdyiSjBi8cbfPTuwbuHdc hlXzGPFV9h27mbgwTeHKVrDj1BinGMA9ehoXHsJoA5ujnwNDN0yoC3n/EouDWjcl2a54Vv ekOrYD9hBAihxa94Ibeo6WivyVWL0bgMwBAqDvJJuxqpSCbJUzqJ4Xe7ylKSxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759071631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DQwzQTJoaNhkGKnhJATWzY0wAk4iagAFxt1crgjRqvI=; b=ZKUEF3Jvhogg9JPp4aqleuRr3+bbkM0ibvtp0OKEhpxygQ4i1tIOJXlxKzD/fMre5vu2a2 b98V5UUuaoejBO5nWLx7fsL46AiGWLfQb7fpSxQMLi7Go3MVMHMO74yqkxABMEd5BRtlst Bc2nyY2l5SuMoMSpRDXDvo+RVWRo+OQs9pSyRaL8RYy4ggsfQZe1yJqTbE3nPG0+uiSokc Fo+mQ/MmKQivFu57pY/0NdZ0Bu5rnTmb0bzriRxsyINMC8kc7GxubUOzsHxZOcHwfc50bz lZUtpO36SMyGOPtkJMswGASJIOV0nC5f1WfpXTRqpkl3LrT7DC6qr9NWx3YHOA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759071631; a=rsa-sha256; cv=none; b=Dv6MErJWZiZ9ZrA2btEvTL0lLOyRDjiHWan8dAT9tr2eY6lbA2EEug8pypr3w0mdvtiXtT 7POug6XXWu5BLpS4Akj1kdSwiQrUMRg78pCxr+FF9nH6/Z+uPwZF2ILn7Gu9tIT6+wWBZz 1fZYT3js4TQk6MO24kvtKWPTzE/+iUm6PVPzi2YCL4tNyDltByL1qU+cbN5hhfIc0WEUWV 2sJgHKJ7klflLTaSiLYEOo6d3Km1kvpwFxhyqsDg8Th4P9z3fC0NYilnXjNh33z80DFDlO 5Wfr47leEJyeUpCdXA99mEPKiBeZXOh22nhPeyDDpVH1vqdZRExo/uoCM1iezg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cZSDb5sVQz888; Sun, 28 Sep 2025 15:00:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58SF0Vsx056610; Sun, 28 Sep 2025 15:00:31 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58SF0VAW056607; Sun, 28 Sep 2025 15:00:31 GMT (envelope-from git) Date: Sun, 28 Sep 2025 15:00:31 GMT Message-Id: <202509281500.58SF0VAW056607@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Rick Macklem Subject: git: 70730cd21c9f - main - rpc_generic.c: Fix a rpcbind core dump when rpcinfo is done List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rmacklem X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 70730cd21c9f2b0a80ff07e4491c0fe30f2d87c5 Auto-Submitted: auto-generated The branch main has been updated by rmacklem: URL: https://cgit.FreeBSD.org/src/commit/?id=70730cd21c9f2b0a80ff07e4491c0fe30f2d87c5 commit 70730cd21c9f2b0a80ff07e4491c0fe30f2d87c5 Author: Rick Macklem AuthorDate: 2025-09-28 14:56:17 +0000 Commit: Rick Macklem CommitDate: 2025-09-28 14:57:34 +0000 rpc_generic.c: Fix a rpcbind core dump when rpcinfo is done Commit c5d671b added netlink support to server side rpcbind. However it did not add a case for AF_NETLINK to __rpc_taddr2uaddr_af(). (Reported as PR#289625.) As such, without this patch the r_addr field of the netlink rbllist is NULL, which causes a crash in svc_sendreply() for a Dump query (what rpcinfo does). PR: 289625 Reviewed by: glebius MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D52651 Fixes: c5d671b711c3 ("libc/rpc: add userland side RPC server over netlink(4)") --- lib/libc/rpc/rpc_generic.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/libc/rpc/rpc_generic.c b/lib/libc/rpc/rpc_generic.c index 0e563f6a5996..8019f2d8f236 100644 --- a/lib/libc/rpc/rpc_generic.c +++ b/lib/libc/rpc/rpc_generic.c @@ -610,6 +610,10 @@ __rpc_taddr2uaddr_af(int af, const struct netbuf *nbuf) return NULL; break; #endif + case AF_NETLINK: + if (asprintf(&ret, "%s", (char *)nbuf->buf) < 0) + return NULL; + break; case AF_LOCAL: sun = nbuf->buf; if (asprintf(&ret, "%.*s", (int)(sun->sun_len -